fix: remove all unauthenticated public endpoints#5637
Open
ink-the-squid wants to merge 1 commit intoHelicone:mainfrom
Open
fix: remove all unauthenticated public endpoints#5637ink-the-squid wants to merge 1 commit intoHelicone:mainfrom
ink-the-squid wants to merge 1 commit intoHelicone:mainfrom
Conversation
Removed 6 controllers with no auth: - alertBannerController (v1/public/alert-banner) - llmSecurityController (v1/public/security) - modelController (v1/models) - modelRegistryController (v1/public/model-registry) - statsController (v1/public/stats/*) - waitlistController (v1/public/waitlist/*) Regenerated TSOA routes/swagger and client types. Note: bifrost public pages (stats, model registry) and web playground (useModelRegistry) reference removed endpoints - will need follow-up to add auth or remove those references.
|
@ink-the-squid is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all controllers that have zero authentication:
alertBannerControllerv1/public/alert-bannerllmSecurityControllerv1/public/securitymodelControllerv1/modelsmodelRegistryControllerv1/public/model-registrystatsControllerv1/public/stats/*waitlistControllerv1/public/waitlist/*Not removed (have
@Securityon class or all methods):heliconeSqlController— no class-level auth but every method has@Security("api_key")proxyController— Express router (not TSOA), separate auth flow@Security("api_key")Known downstream impact:
bifrostpublic pages (stats, model registry, waitlist) reference removed endpointsweb/services/hooks/useModelRegistry.tsxused by playgroundWeb build:
✓ Compiled successfully(pre-existing unrelated type error inportalPage.tsx)