Add conflict-compatible commutative transaction merges - #6
Draft
xav-db wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DbTransaction::merge_commutativeAPI, with the inherent Rust method as the canonical contract and matching trait and UniFFI guidance.unmark_write.Why
SlateDB currently treats blind merge-only updates like exclusive writes. That forces retries on hot keys even when the configured merge operator is order-independent, such as counters, set union, or bitmap union.
The new API makes that stronger algebraic contract explicit. Both operands remain in the normal atomic write batch; only conflict metadata changes, and callers remain responsible for commutativity.
Impact
Applications can opt compatible same-key merge operands out of unnecessary write/write conflicts without weakening read tracking or changing persistence. Existing callers and ordinary merges retain their current conservative behavior.
Validation
cargo llvm-covexecuted the targeted tests successfully, but its final report exporter terminated with SIGSEGV in the local environment.