Skip stale compaction progress metrics - #7
Draft
matthewsanetra wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A compaction can remain in the active set after its source state has disappeared from the current manifest. Metrics collection previously assumed that state was always present and could panic while calculating progress.
Impact
Compaction continues safely when metrics encounter stale work; valid active compactions retain their existing progress accounting.
Validation
cargo fmt --all -- --checkcargo test --package slatedb test_calculate_estimated_source_bytescargo clippy --package slatedb --lib -- -D warningsremains blocked by pre-existing warnings elsewhere in SlateDB; the focused tests pass.