Fix Incorrect Expected Length in Test Assertion#24
Open
t4nature wants to merge 1 commit intoHelixform:masterfrom
Open
Fix Incorrect Expected Length in Test Assertion#24t4nature wants to merge 1 commit intoHelixform:masterfrom
t4nature wants to merge 1 commit intoHelixform:masterfrom
Conversation
This commit corrects the expected length of the code snippet in the test_code function from 19 to 18. The previous length expectation of 19 did not accurately reflect the number of characters in the given code snippet, leading to test failures. The adjustment ensures that the test accurately tests for the correct length of the code snippet, addressing the issue where the test would fail due to an off-by-one error in the length expectation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a failure in the
test_codeunit test, where the expected length of a code snippet was inaccurately set to 19. The correct length, as verified through manual counting and automated tests, is actually 18. This mismatch was causing the test to fail consistently.Changes
test_codefrom 19 to 18.Motivation
The incorrect expectation for the code snippet length in
test_codewas identified as the cause of the test's failure. This issue was misleading, suggesting a problem with the functionality being tested, rather than with the test itself. Correcting this ensures the reliability of our test suite and eliminates confusion regarding the functionality of the related code.Impact
test_codenow passes successfully, increasing our confidence in the test suite.Testing
Request for Review
I request a review to ensure this fix is in line with our testing standards and to confirm there are no overlooked implications of this change.