Skip to content

Fix open_commands actions running after menu item render#287

Open
lukichov1 wants to merge 1 commit into
HelpChat:mainfrom
lukichov1:main
Open

Fix open_commands actions running after menu item render#287
lukichov1 wants to merge 1 commit into
HelpChat:mainfrom
lukichov1:main

Conversation

@lukichov1
Copy link
Copy Markdown

Issue

open_commands, used to reset meta state on menu open, were running one tick after menu open, while items were already being rendered with old state

this caused cases where [meta] values were reset correctly, but placeholders and dynamic_amount could still render stale values on menu open

Fix

run open_commands before item rendering and execute open_commands actions immediately when already on main thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant