Verify ARRAY type handling: add mock and integration tests (legacy #159)#50
Open
HenryNebula wants to merge 1 commit intodevfrom
Open
Verify ARRAY type handling: add mock and integration tests (legacy #159)#50HenryNebula wants to merge 1 commit intodevfrom
HenryNebula wants to merge 1 commit intodevfrom
Conversation
HenryNebula
force-pushed
the
worktree-triage+159-array-type
branch
from
79ad514 to
664374c
Compare
JDBC ARRAY columns are handled via ExplicitTypeMapper's VARCHAR fallback (toString representation). Add mock driver ARRAY support and regression tests to verify this degraded path works correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
HenryNebula
force-pushed
the
worktree-triage+159-array-type
branch
from
664374c to
d2aedcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #49: Verify JDBC ARRAY type (2003) is handled correctly via ExplicitTypeMapper's VARCHAR fallback.
Legacy issue baztian/jaydebeapi#159 reported that ARRAY columns returned raw Java objects. In our codebase, ExplicitTypeMapper already degrades ARRAY to VARCHAR (toString representation), returning Python strings. This PR adds regression tests to verify this behavior.
Changes
ARRAYcase tomockType()in MockConnection.java, mockinggetString()for the VARCHAR fallback pathARRAYfrom_ARROW_UNSUPPORTED_TYPESin test_mock.pyTest plan
CLASSPATH="test/jars/*:test/mock-jars/*" uv run python -m unittest test.test_mockCLASSPATH="test/jars/*" uv run python -m unittest test.test_integration.HsqldbTestCloses #49
Generated with Claude Code