Fix: return empty results from fetch methods after DDL statements#77
Open
HenryNebula wants to merge 1 commit intodevfrom
Open
Fix: return empty results from fetch methods after DDL statements#77HenryNebula wants to merge 1 commit intodevfrom
HenryNebula wants to merge 1 commit intodevfrom
Conversation
HenryNebula
force-pushed
the
triage/76-ddl-fetchall-crash
branch
2 times, most recently
from
33722a6 to
642e8a9
Compare
DDL statements (CREATE TABLE, ALTER TABLE, etc.) produce no ResultSet, so fetchone/fetchall/fetchmany should return None/[] instead of raising Error(). This matches DB-API 2.0 behavior and other implementations. Fixes #76 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
HenryNebula
force-pushed
the
triage/76-ddl-fetchall-crash
branch
from
642e8a9 to
3c9f275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #76: DDL statements (CREATE TABLE, ALTER TABLE, etc.) produce no ResultSet, so
fetchone(),fetchall(), andfetchmany()should returnNone/[]instead of raisingError(). This matches DB-API 2.0 behavior and other implementations like psycopg2 and sqlite3.Changes
fetchone(): returnNonewhen no ResultSet (instead of raisingError())fetchmany(): return[]when no ResultSet (instead of raisingError())fetchall(): return[]when no ResultSet (instead of raisingError())mockDDLResult()to MockConnection for testing DDL statementsTest plan
Closes #76
Generated with Claude Code