Add jvm_args parameter to connect() for custom JVM arguments (fixes #90)#91
Open
HenryNebula wants to merge 1 commit intodevfrom
Open
Add jvm_args parameter to connect() for custom JVM arguments (fixes #90)#91HenryNebula wants to merge 1 commit intodevfrom
HenryNebula wants to merge 1 commit intodevfrom
Conversation
HenryNebula
force-pushed
the
triage/90-jvm-args-param
branch
from
670cf99 to
be9846f
Compare
Users can now pass custom JVM arguments (e.g., -Duser.timezone, -Dfile.encoding=UTF-8) via the jvm_args parameter. These are applied on the first connect() call when the JVM starts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
HenryNebula
force-pushed
the
triage/90-jvm-args-param
branch
from
be9846f to
db8eb92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #90: Adds a
jvm_argsparameter toconnect()allowing users to pass custom JVM arguments (e.g.,-Duser.timezone=America/Toronto,-Dfile.encoding=UTF-8).Previously, there was no way to pass custom JVM arguments. The codebase even had a TODO comment referencing this exact feature. This resolves legacy issue baztian/jaydebeapi#161.
Changes
jvm_argsparameter toconnect()and_jdbc_connect_jpype()jvm_argsTest plan
test_connect_accepts_jvm_argsin test_mock.pytest_jvm_args_sets_system_propertyin test_integration.pyCloses #90
Generated with Claude Code