Fix: validate url parameter is a string in connect() (issue #95)#96
Open
HenryNebula wants to merge 1 commit intodevfrom
Open
Fix: validate url parameter is a string in connect() (issue #95)#96HenryNebula wants to merge 1 commit intodevfrom
HenryNebula wants to merge 1 commit intodevfrom
Conversation
When users pass a list as the url parameter (e.g., mixing up url and driver_args), JPype throws an opaque "No matching overloads found for getConnection" TypeError. Add a Python-level validation with a clear error message that explains the correct argument order. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #95: Users passing a list/dict as the
urlparameter (common mistake when mixing upurlanddriver_args) got an opaque JPypeTypeError: No matching overloads found for getConnection. Now raises a clearProgrammingErrorwith usage guidance.Changes
isinstance(url, str)validation at the top ofconnect()injaydebeapiarrow/__init__.pyconnect(jclassname, url, driver_args=None, jars=None, libs=None)Test plan
ConnectValidationTestintest/test_mock.py(list and dict cases)test/test_integration.pyCloses #95
Generated with Claude Code