DigitalSequenceBlock instead of list for hmmer#18
Open
kbseah wants to merge 1 commit intoHerwigLab:masterfrom
Open
DigitalSequenceBlock instead of list for hmmer#18kbseah wants to merge 1 commit intoHerwigLab:masterfrom
kbseah wants to merge 1 commit intoHerwigLab:masterfrom
Conversation
See MatthiasLienhard#12 and althonos/pyhmmer#87 pyhmmer>=0.11.1 will raise TypeError with unsupported types If list can fit in memory, DigitalSequenceBlock should too
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses MatthiasLienhard#12
See also: althonos/pyhmmer#87
pyhmmer>=0.11.1 will raise TypeError with unsupported types
Re memory usage: If a list can fit in memory, a DigitalSequenceBlock should too