fix: 일반 멤버 방 탈퇴 처리 - #18
Merged
Merged
Conversation
Heyaaz
commented
May 20, 2026
Heyaaz
left a comment
Owner
Author
There was a problem hiding this comment.
Nogada PR Review
Verdict: Approved ✅
확인한 내용
- 일반 멤버
DELETE /rooms/{roomId}요청 시 방 삭제가 아니라 본인 멤버십/프로필/만족도 점수만 soft delete 처리되는지 확인 - 방장 삭제 시 방/일정/슬롯/만족도/갈등지도/멤버/프로필/사진 아카이브 soft delete 흐름 확인
- 탈퇴한 멤버가 기존 방 상세 접근 권한을 잃고, 방장 입장에서는 방과 공유코드가 유지되는지 확인
- 재입장 시 soft-deleted
RoomMember를 재활성화해서 unique constraint 충돌을 피하는 흐름 확인
Blocking Issues
- 없음
Non-blocking Notes
clean test종료 시 Testcontainers/PostgreSQL shutdown 로그가 noisy하게 찍히지만, Gradle 결과와 XML 요약 기준 테스트 실패는 없음
Verification
- ✅
git diff --check origin/main...pr-18 - ✅
./gradlew clean test --no-daemon --no-build-cache - ✅ Test XML: 49 tests, 0 failures, 0 errors, 0 skipped
[Heyaaz의 Nogada]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Verification
Commands:
./gradlew compileKotlin compileTestKotlin./gradlew test --tests com.tripsync.AuthContractTestsNotes
/var/run/docker.sock없음