feat: 지역상생 일정 추천 구현 - #19
Merged
Merged
Conversation
Heyaaz
commented
May 20, 2026
Heyaaz
left a comment
Owner
Author
There was a problem hiding this comment.
Nogada PR Review
Verdict: ✅ No blocking issues found.
Checked scope:
- 지역상생 추천을 위한 외부 인기도 지표 수집/저장 흐름
- 일정 후보 필터링, 지역/숨은명소/인기도 기반 랭킹, 슬롯 중복 방지 로직
- 다일자 여행방 날짜 범위 추가 및 응답 매핑 변경
- 공개 사진 프록시 엔드포인트와 SecurityConfig 허용 범위
- 신규/변경 테스트 및 DB migration
Verification:
./gradlew clean test --no-daemon --no-build-cache성공- Test XML summary: 59 tests, 0 failures, 0 errors, 0 skipped
git diff --check origin/main...pr-19에서V9__add_trip_room_date_range.sqlEOF blank line 1건만 확인됨. 동작 영향 없는 포맷 이슈라 non-blocking으로 봤습니다.
Notes:
- Testcontainers 종료 시점의 Hikari/PostgreSQL shutdown warning은 있었지만 Gradle 빌드와 XML 결과는 성공입니다.
[Heyaaz의 Nogada]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Verification
./gradlew test --tests 'com.tripsync.application.consensus.ConsensusServiceTest' --no-daemon./gradlew test --tests 'com.tripsync.application.consensus.ConsensusServiceTest' --tests 'com.tripsync.infrastructure.llm.OpenAiClientTest' --no-daemon./gradlew cleanTest test --no-daemonNotes