fix: 일정 생성 버전 충돌 방지 - #21
Merged
Merged
Conversation
Heyaaz
commented
May 20, 2026
Heyaaz
left a comment
Owner
Author
There was a problem hiding this comment.
Nogada PR Review
Verdict
✅ Blocking 이슈 없음. 병합 가능해 보입니다.
확인한 내용
ScheduleGenerationPersistenceService.saveGeneratedOptions에서 방 row를PESSIMISTIC_WRITE로 잠근 뒤 최신 schedule version을 계산하도록 바뀐 점 확인했습니다.- 같은 방에 동시 일정 생성 저장이 들어와도 version이 중복되지 않도록
TripRoomRepository.findActiveByIdForUpdate가 추가된 점 확인했습니다. - 동시 저장 회귀 테스트가 version
2, 3, 4, 5를 검증하도록 추가된 점 확인했습니다.
검증
./gradlew clean test --no-daemon --no-build-cache성공- 테스트 XML 기준: 61 tests / 0 failures / 0 errors / 0 skipped
git diff --check origin/main...HEAD통과
참고
- 테스트 종료 시 Testcontainers/Hikari/PostgreSQL shutdown warning이 출력됐지만, Gradle 결과와 XML 요약은 정상 성공이라 blocking으로 보지 않았습니다.
[Heyaaz의 Nogada]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Verification
./gradlew test --tests 'com.tripsync.application.schedule.ScheduleServiceTest' --no-daemon./gradlew cleanTest test --no-daemonNotes