Refactor: OAuth 응답 및 LLM 메타데이터 정리 - #23
Merged
Merged
Conversation
Heyaaz
commented
May 24, 2026
Heyaaz
left a comment
Owner
Author
There was a problem hiding this comment.
Nogada PR Review
Verdict: Approved ✅
Blocking Issues
- 없음.
Notes
OAuth2UserService의 Google/Kakao 사용자 조회·생성 및 인증 응답 생성 로직이 공통 함수로 분리됐고, 기존 응답 필드(token,userId,nickname,email,authProvider)는 유지됩니다.ScheduleResponseMapper의 LLM 메타데이터 캐스팅이Map<*, *>기반으로 정리되어 unchecked cast 경고 제거 목적에 맞습니다.- 테스트 종료 시 Testcontainers/Hikari/PostgreSQL shutdown warning이 출력됐지만, Gradle은 성공 종료했고 XML 결과도 실패/에러 0건이라 비차단으로 봤습니다.
Verification
- ✅
git diff --check origin/main...pr-23 - ✅
./gradlew clean test --no-daemon --no-build-cache - ✅ Test XML: 12 files / 65 tests / 0 failures / 0 errors / 0 skipped
[Heyaaz의 Nogada]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Verification
./gradlew test./gradlew test --tests com.tripsync.AuthContractTests./gradlew test --tests com.tripsync.application.schedule.ScheduleResponseMapperTest --tests com.tripsync.AuthContractTests./gradlew checkNotes