fix: 인증 오류와 일정 상세 메타 개선 - #24
Merged
Merged
Conversation
Heyaaz
commented
May 29, 2026
Heyaaz
left a comment
Owner
Author
There was a problem hiding this comment.
Nogada PR Review
Verdict: Approved ✅
Blocking 이슈는 발견하지 못했습니다.
확인한 범위
- OAuth 로그인 공통 응답 생성 리팩터링 및 중복 사용자 생성 흐름
- 로컬 회원가입/로그인 실패 시 HTTP 409/401로 내려가도록 바뀐 인증 계약
- 일정 상세 응답의 이미지 fallback 및 popularity 메타 노출
- 참고군 검증 문구가 개인명/내부 reason을 덜 노출하도록 바뀐 로직
- 추가/수정된 테스트 커버리지
검증
- ✅
git diff --check origin/main...HEAD - ✅
./gradlew clean test --no-daemon --no-build-cache - ✅ 테스트 XML 요약: 12 files / 70 tests / 0 failures / 0 errors / 0 skipped
참고: 테스트 종료 시 Testcontainers/Hikari shutdown warning이 있었지만 Gradle은 성공했고 XML 실패도 0건이라 비차단 로그로 판단했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Verification
Notes