백엔드 조회 최적화 및 오류 응답 강화 - #26
Merged
Merged
Conversation
Shared photo album P0 stores image bytes in PostgreSQL bytea, so the repository test covers visible-photo filtering, soft-delete exclusion, and byte-array round trips. The entity mapping now binds content as binary data instead of a PostgreSQL large-object OID. Constraint: P0 stores photo files in DB bytea while object storage is deferred Rejected: Keep @lob mapping | Hibernate persisted an OID/bigint and failed against bytea Confidence: high Scope-risk: narrow Tested: ./gradlew testClasses --no-daemon Tested: ./gradlew test --tests com.tripsync.domain.repository.TripPhotoRepositoryTest --no-daemon Not-tested: Full ./gradlew test suite due leader instruction to finish current slice with focused evidence
The album UI needs authenticated endpoints for listing slot-grouped memories, uploading DB-backed image bytes, returning inline image content, and applying uploader/host moderation rules. Constraint: P0 stores files in DB bytea and excludes public album sharing Constraint: S3/object storage remains a future extension boundary rather than a P0 dependency Rejected: Public /share photo endpoints | photo consent and moderation model are not ready for P0 Confidence: high Scope-risk: moderate Tested: ./gradlew compileKotlin --no-daemon Tested: ./gradlew test --tests com.tripsync.domain.repository.TripPhotoRepositoryTest --no-daemon Not-tested: Full end-to-end multipart upload through browser
Heyaaz
marked this pull request as ready for review
July 8, 2026 01:38
Heyaaz
commented
Jul 8, 2026
Heyaaz
left a comment
Heyaaz
left a comment
Owner
Author
There was a problem hiding this comment.
Nogada PR Review
Verdict
- 승인 가능: blocking 이슈 없음
Blocking issues
- 없음
Non-blocking notes
./gradlew clean test --no-daemon --no-build-cache는 fresh detached worktree에서 성공함.- 테스트 종료 시 Hibernate/Testcontainers 정리 로그가 다소 noisy하지만, Gradle exit 0이고 XML 기준 실패/에러 없음.
Checked scope
- room/schedule 조회 경로 최적화: member count, schedule summary, stored schedule detail assembly
- TourAPI sync/enrich 트랜잭션 경계 및 retry/failure accounting
- Flyway V11/V12 마이그레이션과 인덱스/타입 정합성
- malformed JSON/invalid auth/soft-delete/public share/hostile text contract 테스트
- 검증:
git diff --check origin/main...pr-26통과 - 검증: test XML summary
files=16, tests=84, failures=0, errors=0, skipped=0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
git diff --checkDOCKER_HOST=unix:///Users/byeonheejae/.docker/run/docker.sock ./gradlew compileTestKotlinDOCKER_HOST=unix:///Users/byeonheejae/.docker/run/docker.sock ./gradlew test --rerun-tasksNotes