Refactor: 백엔드 추천 성능 최적화 - #27
Merged
Merged
Conversation
Heyaaz
commented
Jul 8, 2026
Heyaaz
left a comment
Owner
Author
There was a problem hiding this comment.
Nogada PR Review
Verdict
- 승인 가능: blocking 이슈 없음
Blocking issues
- 없음
Non-blocking notes
./gradlew clean test --no-daemon --no-build-cache는 fresh detached worktree에서 성공함.- 테스트 종료 시 Hibernate/Testcontainers 정리 로그가 noisy하지만, Gradle exit 0이고 XML 기준 실패/에러 없음.
Checked scope
- 추천 생성 성능 최적화: LLM refinement 병렬 실행, per-option timeout/fallback, timing log
- LLM refined slot 이후 cross-option same-order 중복 제거 로직
- schedule generation persistence의 place/user batch lookup 및 child
saveAll경로 - 방 상세 scheduleState batch formatting, schedule detail metrics/scores/slots batch 조회
- external popularity sync의 bounded page query
- 검증:
git diff --check origin/main...pr-27통과 - 검증: test XML summary
files=18, tests=88, failures=0, errors=0, skipped=0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Verification
Not run
Build
Test
Manual
./gradlew compileKotlin compileTestKotlin --console=plainDOCKER_HOST=unix:///Users/byeonheejae/.docker/run/docker.sock ./gradlew test --tests '*RoomScheduleQueryCountTest' --tests '*ScheduleGenerationPerformanceTest' --tests '*ExternalPopularity*' --console=plainDOCKER_HOST=unix:///Users/byeonheejae/.docker/run/docker.sock ./gradlew test --tests '*ConsensusServiceTest' --tests '*ScheduleServiceTest' --tests '*ScheduleGenerationPerformanceTest' --console=plainDOCKER_HOST=unix:///Users/byeonheejae/.docker/run/docker.sock ./gradlew test --console=plainNotes