Skip to content

[F3-2] Update minor issues in admin portal#26

Merged
dnishiyama merged 7 commits intodevfrom
fix/f3-2-minor-issues-from-multi-pr
Apr 20, 2026
Merged

[F3-2] Update minor issues in admin portal#26
dnishiyama merged 7 commits intodevfrom
fix/f3-2-minor-issues-from-multi-pr

Conversation

@elsiedp
Copy link
Copy Markdown

@elsiedp elsiedp commented Mar 25, 2026

👋 TL;DR

  • Updated user router to allow role changes while preventing profile modifications for users outside the admin's managed home region.
  • Refactored user update logic to streamline authorization checks and ensure existing user data is preserved when unauthorized edits are attempted.
  • Enhanced tests to validate the new behavior, ensuring that profile fields remain unchanged while roles can still be updated.

🔎 Details

(coming soon)

✅ How to Test

(coming soon)

🥜 GIF

lack-of-hustle

@elsiedp elsiedp requested a review from dnishiyama as a code owner March 25, 2026 16:33
@makeplane
Copy link
Copy Markdown

makeplane Bot commented Mar 25, 2026

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@elsiedp elsiedp force-pushed the fix/f3-2-minor-issues-from-multi-pr branch from 4728c3d to 0e8295a Compare March 25, 2026 16:52
elsiedp and others added 7 commits April 14, 2026 12:46
* Update modals and add mobile filter sheet

- Updated various modal components to improve layout and responsiveness, including adjustments to class names for better styling.
- Introduced a new MobileFilterSheet component for mobile devices to manage filters more effectively.
- Integrated MobileFilterSheet into AOsTable, AreasTable, and other relevant components to enhance user experience on smaller screens.
- Adjusted filter handling logic to accommodate the new mobile filter interface.

* Enhance admin layout with titles and z-index adjustments

- Added a title prop to the Layout component for better page identification across various admin pages.
- Updated the z-index for the header to ensure proper stacking context.
- Adjusted padding for content areas to improve layout consistency.
- Modified several admin pages to utilize the new title feature, enhancing user experience and accessibility.
- Introduced EVENT_CATEGORY_OPTIONS and EVENT_CATEGORY_LABEL_MAP constants for better management of event categories.
- Updated LocationEventForm, AdminEventTypesModal, and AdminWorkoutsModal to utilize the new constants for displaying event category labels.
- Improved label formatting to include category descriptions where applicable.
…modifications for users outside the admin's managed home region.

- Refactored user update logic to streamline authorization checks and ensure existing user data is preserved when unauthorized edits are attempted.
- Enhanced tests to validate the new behavior, ensuring that profile fields remain unchanged while roles can still be updated.
@elsiedp elsiedp force-pushed the fix/f3-2-minor-issues-from-multi-pr branch from b3cf4f2 to cf002f9 Compare April 14, 2026 04:47
Copy link
Copy Markdown

@dnishiyama dnishiyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dnishiyama dnishiyama merged commit 52b1e84 into dev Apr 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants