Conversation
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
🎯 **What:** The testing gap addressed This PR significantly improves the test coverage for the `useFocusTrap` hook. Previously, there were only 4 basic test cases covering the happy paths of the hook (opening menu, basic tabbing, clicking outside). Now the hook behavior is extensively verified across all focus management edge cases. 📊 **Coverage:** What scenarios are now tested - Handling of 'Empty' menus/focus traps with no actual focusable child elements. - Edge cases for `activeElement` correctly navigating around boundaries when Tab/Shift+Tab is pressed. - Pointer down edge cases on objects that are not true HTML `Node` elements. - Correctly skipping over elements with `disabled` or `aria-hidden="true"` attributes when creating the inner trap array. - Scenarios where refs (`dialogRef.current`) are missing or improperly initialized. - Component cleanup during unmounting. ✨ **Result:** The improvement in test coverage The test coverage for `useFocusTrap` went from ~67% to 100% statement and branch coverage (19 total test cases), ensuring robust accessibility features for all standard focus interactions. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
Removes `aria-live="polite"` and `aria-atomic="true"` from character counters in `apps/web/src/app/collections/new/page.tsx` and `apps/web/src/app/orgs/new/page.tsx`. These attributes cause screen readers to announce the character count on every single keystroke, creating an extremely noisy and annoying experience. Since the `textarea` elements already have `aria-describedby` correctly pointing to the counters, `aria-live` is redundant and actively harmful here. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
chore: sync main into staging
github-actions
Bot
added
automated
Contributor
|
No reviewable files after applying ignore patterns. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…-counter-4045675348734869958 🎨 Palette: 入力フィールドの文字数カウンターからaria-liveを削除
github-actions
Bot
changed the title
…316984129109700 ⚡ perf: optimize tags de-duplication loop from O(N^2) to O(N)
github-actions
Bot
changed the title
…e3d58e 🧪 Add comprehensive tests for useFocusTrap hook
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes
stagingintomain.stagingmainnpm run pr:promoteIncluded PRs
Compare