🧪 Add test for invalid JSON body in test-auth route#1091
Conversation
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new test case to verify that the test-auth route returns a 400 status code and an 'Invalid JSON' error message when the request body contains malformed JSON. The reviewer suggests refactoring the JSON assertion to use await expect(res.json()).resolves.toEqual(...) to improve test robustness and handle potential parsing errors gracefully.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
このリポジトリでは staging 先行フローを採用しています。PR のターゲットを |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@greptile review |
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
|
Closing because this formerly single-test PR is now contaminated with workflow, package-lock, origin utility, and settings-page changes and is conflicting with staging. |
is0692vs
left a comment
is0692vs
left a comment
There was a problem hiding this comment.
Resolved by addressing the JSON assertion feedback.
1 participant
🎯 What: Added missing test for invalid JSON body parsing in the test-auth token route.
📊 Coverage: Added coverage for the catch block of
c.req.json()in POST/api/test-auth/test-token.✨ Result: Improved test reliability by ensuring malformed JSON payloads correctly return a 400 Bad Request error.
PR created automatically by Jules for task 16377955958524039310 started by @is0692vs
Greptile Summary
POST /api/test-auth/test-tokenルートのc.req.json()が失敗する catch ブロックのカバレッジを補うため、不正な JSON ボディを送信した場合のテストを 1 件追加しました。"{ invalid json "という壊れたボディを送り、ハンドラの catch パスを直接検証しています。{ error: "Invalid JSON" }）の両方をアサートしており、実装の仕様と一致しています。Confidence Score: 5/5
テストのみの変更でプロダクションコードには一切触れておらず、安全にマージできます。
追加されたテストは既存のルート実装の catch ブロックを正確にカバーしており、ミドルウェアの認証フローも正しく通過させています。ステータスコードとレスポンスボディの両方をアサートしており、テストロジックに問題は見当たりません。
特に注意が必要なファイルはありません。
Important Files Changed
Sequence Diagram
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant Test as テストコード participant MW as testAuth ミドルウェア participant Handler as POST /test-token ハンドラ Test->>MW: "POST /api/test-auth/test-token<br/>x-test-auth-secret: correct-secret<br/>body: { invalid json" MW->>MW: "ENABLE_TEST_AUTH === true ✓<br/>TEST_AUTH_SECRET 存在確認 ✓<br/>timingSafeEqual 検証 ✓" MW->>Handler: next() Handler->>Handler: c.req.json() → SyntaxError (catch) Handler-->>Test: "400 { error: Invalid JSON }"%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant Test as テストコード participant MW as testAuth ミドルウェア participant Handler as POST /test-token ハンドラ Test->>MW: "POST /api/test-auth/test-token<br/>x-test-auth-secret: correct-secret<br/>body: { invalid json" MW->>MW: "ENABLE_TEST_AUTH === true ✓<br/>TEST_AUTH_SECRET 存在確認 ✓<br/>timingSafeEqual 検証 ✓" MW->>Handler: next() Handler->>Handler: c.req.json() → SyntaxError (catch) Handler-->>Test: "400 { error: Invalid JSON }"Reviews (2): Last reviewed commit: "Merge branch 'staging' into test-invalid..." | Re-trigger Greptile