Skip to content

ci(sync): remove hardcoded assignee/reviewer fallback - #348

Merged
is0692vs merged 1 commit into
stagingfrom
fix/staging-sync-pr-vars-default
Apr 7, 2026
Merged

ci(sync): remove hardcoded assignee/reviewer fallback#348
is0692vs merged 1 commit into
stagingfrom
fix/staging-sync-pr-vars-default

Conversation

@is0692vs

@is0692vs is0692vs commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove hardcoded is0692vs fallback for sync PR assignees/reviewers
  • keep values driven by repository variables (or empty)

Why

Follow-up CodeRabbit review on PR #345 requested that sync PR assignee/reviewer defaults not be tied to a fixed username.

Greptile Summary

このPRは、sync PRの自動生成時に SYNC_PR_ASSIGNEES および SYNC_PR_REVIEWERS のフォールバック値としてハードコードされていたユーザー名 is0692vs を削除し、空文字列 '' へ変更します。PR #345 に対する CodeRabbit のレビュー指摘を受けたフォローアップです。

  • .github/workflows/sync-main-to-staging.ymlSYNC_PR_ASSIGNEESSYNC_PR_REVIEWERS のフォールバックを 'is0692vs''' に変更
  • ラベルのフォールバック (sync,automated) は汎用的なため引き続き維持
  • sync-main-to-staging.sh 内の parse_csv_values 関数は空文字列を正しく処理するため、スクリプト側の変更は不要
  • リポジトリ変数 (vars.SYNC_PR_ASSIGNEES / vars.SYNC_PR_REVIEWERS) が設定されていない場合、assignee・reviewer なしで PR が作成される

Confidence Score: 5/5

変更は最小限かつ安全で、マージに問題なし。

ハードコードされたユーザー名を空文字列へ置き換えるだけのシンプルな1行変更が2箇所。シェルスクリプト側の空値ハンドリング(parse_csv_values)も適切に実装されており、P1以上の問題は見当たらない。

特になし。

Important Files Changed

Filename Overview
.github/workflows/sync-main-to-staging.yml ハードコードされた is0692vs フォールバックを削除し空文字列に変更。スクリプトの動作に影響なし。

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant WF as sync-main-to-staging.yml
    participant SH as sync-main-to-staging.sh
    participant API as GitHub API

    GH->>WF: push to main / workflow_dispatch
    WF->>WF: 環境変数を設定<br/>SYNC_PR_ASSIGNEES = vars.SYNC_PR_ASSIGNEES \|\| ''<br/>SYNC_PR_REVIEWERS = vars.SYNC_PR_REVIEWERS \|\| ''
    WF->>SH: bash スクリプト実行
    SH->>API: 既存 PR を確認
    alt 既存 PR なし かつ コミット差分あり
        SH->>API: gh pr create<br/>(変数が空の場合 --assignee / --reviewer はスキップ)
    else 既存 PR あり または 差分なし
        SH-->>GH: exit 0
    end
Loading

Reviews (1): Last reviewed commit: "ci(sync): remove hardcoded sync assignee..." | Re-trigger Greptile

Use repository variables (or empty values) for SYNC_PR_ASSIGNEES and SYNC_PR_REVIEWERS so sync automation stays configurable and avoids a fixed username.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vercel

vercel Bot commented Apr 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
open-shelf Ignored Ignored Apr 7, 2026 8:26am

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f2b6003c-a0d3-48d3-abd7-04984b9549a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/staging-sync-pr-vars-default

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq

codspeed-hq Bot commented Apr 7, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks
⏩ 15 skipped benchmarks1


Comparing fix/staging-sync-pr-vars-default (a5538a9) with staging (6d42ba1)

Open in CodSpeed

Footnotes

  1. 15 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@dosubot dosubot Bot added the github_actions Pull requests that update GitHub Actions code label Apr 7, 2026
@codecov

codecov Bot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@is0692vs
is0692vs merged commit e883925 into staging Apr 7, 2026
16 checks passed
@is0692vs
is0692vs deleted the fix/staging-sync-pr-vars-default branch April 7, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant