Conversation
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to "すべての研究データを一箇所に。共有も管理も、これまで以上に簡単に。" - Adjust landing page typography (`sm:text-5xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to "すべての研究データを一箇所に。共有も管理も、これまで以上に簡単に。" - Adjust landing page typography (`sm:text-5xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to "すべての研究データを一箇所に。共有も管理も、これまで以上に簡単に。" - Adjust landing page typography (`sm:text-5xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to "すべての研究データを一箇所に。共有も管理も、これまで以上に簡単に。" - Adjust landing page typography (`sm:text-5xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to a shorter, punchier phrase: "研究データを一箇所に / 共有も管理もスマートに" - Adjust landing page typography (`sm:text-6xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to a shorter, punchier phrase: "研究データを一箇所に / 共有も管理もスマートに" - Adjust landing page typography (`sm:text-6xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to a shorter, punchier phrase: "研究データを一箇所に / 共有も管理もスマートに" - Adjust landing page typography (`sm:text-6xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to a shorter, punchier phrase: "研究データを一箇所に / 共有も管理もスマートに" - Adjust landing page typography (`sm:text-6xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to a shorter, punchier phrase: "研究データを一箇所に / 共有も管理もスマートに" - Adjust landing page typography (`sm:text-6xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Change "論文" to "成果物" (Outputs/Artifacts) across the app to reflect broader support for slides, data, and supplementary materials. - Change "マイ論文" to "マイライブラリ" (My Library). - Redesign the landing page hero copy from "研究成果物を保存し、共有する。" to a shorter, punchier phrase: "研究データを一箇所に / 共有も管理もスマートに" - Adjust landing page typography (`sm:text-6xl text-balance`) to fit new copy while maintaining the requested level of flashiness. - Update related metadata, labels, error messages, empty states, and test assertions to match the new terms. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
…er button Fixes CI E2E failures caused by renaming "論文" to "成果物". Updates locators in auth-flow.spec.ts, org-management.spec.ts, and cross-feature.spec.ts. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
…shold - Fix 成果物 tab button formatting in settings page (inline to indented) - Fix E2E test description: 論文タイトル → 成果物タイトル (CodeRabbit) - Add empty-state test for OrgCollectionPageClient - Add 404 error test for PaperDetailClient Agent-Logs-Url: https://github.com/Hiroki-org/OpenShelf/sessions/def1fbc2-0f7a-466c-a9ec-efb673412f68 Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hiroki-org/OpenShelf/sessions/def1fbc2-0f7a-466c-a9ec-efb673412f68 Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Formatted the 成果物 button in `orgs/[slug]/settings/page.tsx` for visual consistency. - Replaced 論文 with 成果物 in `papers.spec.ts` description header as requested. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Formatted the 成果物 button in `orgs/[slug]/settings/page.tsx` for visual consistency. - Replaced 論文 with 成果物 in `papers.spec.ts` description header as requested. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Update E2E locators in `auth-flow.spec.ts`, `org-management.spec.ts`, and `cross-feature.spec.ts` to reflect the UI terminology change from "論文" to "成果物", fixing the CI E2E failures. - Update `papers.spec.ts` test description string to replace "論文タイトル" with "成果物タイトル" as requested by CodeRabbit. - Refactor the "成果物" tab button in `orgs/[slug]/settings/page.tsx` to use map-based data generation matching adjacent tabs as requested in the PR review. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Added `isDragging` state to track drag-over events. - Updated the upload button styling to change border, background, and text color when a file is dragged over. - Changed the instructional text dynamically to "ドロップして追加" (Drop to add) during drag-over for better visual feedback. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
非同期処理中(保存、削除、招待、追加など)のボタンについて、単にテキストを「保存中...」などに変更するだけでなく、視覚的に処理中であることが分かるよう、Tailwind CSSを用いたローディングスピナーを追加しました。これにより、より直感的なUXを提供します。 Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
- Added test cases in `apps/web/src/app/upload/__tests__/page.test.tsx` to verify `onDragOver`, `onDragLeave`, and `onDrop` handlers. - Simulated drag events via `fireEvent` to ensure visual feedback state toggles properly and `addFiles` triggers upon drop. - Improved Codecov coverage to resolve CI failure. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
🚨 深刻度: HIGH 💡 脆弱性: tag suggestionsにおける不完全な文字列置換によるSQLワイルドカードインジェクションの脆弱性。 🎯 影響: エスケープされていないワイルドカードによるアルゴリズム複雑性のサービス拒否 (DoS)。 🔧 修正: `apps/api/src/utils/sql.ts`に `escapeLikeLiteral` を標準化し、一貫して使用するように修正。 ✅ 検証: ユニットテストを追加し、既存のルーティングテストに対して修正を検証済み。 Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- orgsのメンバーおよび論文の追加ボタンにおいて、リスト内で押された特定のボタンにのみスピナーが表示されるように修正 - 論文のCiteボタンにおいて、スピナー表示時もラベルテキスト(または「生成中...」)を残すように修正し、スクリーンリーダー向けの説明を維持 - .Jules/palette.md 内の重複したエントリーを削除 Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
- Added `onDragEnter` to properly toggle drag state. - Fixed `handleDragLeave` to ignore events triggered when hovering over child elements by validating `currentTarget.contains(relatedTarget)`. - Validated dropped file extensions to prevent unsupported types from bypassing the `<input accept="..." />` restriction via drag-and-drop. - Added comprehensive unit tests simulating drag-and-drop behavior with robust JSDOM workarounds for `relatedTarget` and `DataTransfer`. Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
…hout trailing comma" This reverts commit bc66c05.
…62783403-fa116556
…-ux-13480145486604963118
…116556 タグ入力時の末尾タグの表示改善とリファクタリング
…-ux-13480145486604963118
…5486604963118 🎨 Palette: アップロード領域にドラッグ&ドロップ機能と視覚的フィードバックを追加
…47fc1 feat: トップページのキャッチコピー改善と「論文」から「成果物/ライブラリ」への用語変更
`apps/api/src/routes/papers.ts` の `getClientIp` 関数から、`X-Forwarded-For` ヘッダーを利用したIPアドレス取得のフォールバックを削除しました。 Cloudflare Workersのような環境では、`CF-Connecting-IP` が信頼できる唯一のクライアントIPのソースとなります。`X-Forwarded-For` をフォールバックとして残しておくと、悪意のあるクライアントがリクエストヘッダーを偽装することで、IPベースのレート制限やアクセス制御を回避する「IPスプーフィング」の脆弱性につながるため、この記述を完全に削除しました。 また、Honoの `req.header()` は大文字・小文字を区別しないため、不要な `cf-connecting-ip` の重複チェックも整理しました。 Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
…erability-10754333442610924551 🛡️ Sentinel: [CRITICAL] IPスプーフィング脆弱性の修正 (X-Forwarded-For フォールバックの削除)
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
…markdown-test-console-log-1429334881030692758
…st-console-log-1429334881030692758 🧹 Remove unused console.log in test file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes
stagingintomain.stagingmainnpm run pr:promoteIncluded PRs
Compare