Skip to content

⚡ Refactor getTopK to use standard array operations #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
is0692vs merged 2 commits into from
Jul 13, 2026
+5 −16
Merged

⚡ Refactor getTopK to use standard array operations #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18d062e
perf: optimize getTopK with standard array operations
google-labs-jules[bot] Jul 10, 2026
4698900
fix: clamp top-k result limit
is0692vs Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions src/lib/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,24 +743,13 @@ export const fetchActivity = cache(async function fetchActivity(

/**
* 効率的に Map から上位 K 件を抽出するヘルパー関数
* 配列の作成とソートを最小限に抑えることでパフォーマンスを向上させます
* 上位 K 件だけを返します。
*/
function getTopK(map: Map<string, number>, k: number = 10): { name: string; count: number }[] {
const top: { name: string; count: number }[] = [];
for (const [name, count] of map.entries()) {
if (top.length < k) {
top.push({ name, count });
top.sort((a, b) => b.count - a.count);
} else if (count > top[k - 1].count) {
let i = k - 2;
while (i >= 0 && top[i].count < count) {
top[i + 1] = top[i];
i--;
}
top[i + 1] = { name, count };
}
}
return top;
const limit = Math.max(0, k);
return Array.from(map, ([name, count]) => ({ name, count }))
.sort((a, b) => b.count - a.count)
.slice(0, limit);
}

/**
Expand Down
Loading