🧹 Refactor fetchStarredRepos for better readability#455
Conversation
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const topicCounts = aggregateTopics(allStarred); | ||
| const languageCounts = aggregateLanguages(allStarred); |
There was a problem hiding this comment.
リファクタリングにより allStarred を aggregateTopics と aggregateLanguages の2つの関数でそれぞれ走査するようになりました。元のコードは1回のループでトピックと言語を同時に集計していたため、イテレーション数が2倍になっています。最大200件（100件×2ページ）という規模なので実際のパフォーマンス影響はほぼ無視できますが、可読性のために行ったリファクタリングで計算量が増えている点は把握しておくとよいでしょう。
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/lib/github.ts
Line: 697-698
Comment:
**リストの二重イテレーション**
リファクタリングにより `allStarred` を `aggregateTopics` と `aggregateLanguages` の2つの関数でそれぞれ走査するようになりました。元のコードは1回のループでトピックと言語を同時に集計していたため、イテレーション数が2倍になっています。最大200件（100件×2ページ）という規模なので実際のパフォーマンス影響はほぼ無視できますが、可読性のために行ったリファクタリングで計算量が増えている点は把握しておくとよいでしょう。
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily applies formatting updates across src/lib/github.ts and refactors fetchStarredRepos by extracting aggregateTopics and aggregateLanguages helper functions. The review feedback highlights a potential out-of-bounds array access in fetchActivity where the manually parsed hour value is used directly as an index without validation, and suggests adding a safety check to handle malformed input strings.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| const hour = | ||
| (createdAt.charCodeAt(11) - charCodeZero) * 10 + | ||
| (createdAt.charCodeAt(12) - charCodeZero); |
There was a problem hiding this comment.
The manually parsed hour value is used directly as an array index for heatmap[day]. If the createdAt string is malformed or unexpected, hour could be NaN or outside the valid range of [0, 23], leading to out-of-bounds access or runtime errors. Please validate the parsed hour value before using it as an index.
| const hour = | |
| (createdAt.charCodeAt(11) - charCodeZero) * 10 + | |
| (createdAt.charCodeAt(12) - charCodeZero); | |
| const parsedHour = | |
| (createdAt.charCodeAt(11) - charCodeZero) * 10 + | |
| (createdAt.charCodeAt(12) - charCodeZero); | |
| const hour = parsedHour >= 0 && parsedHour < 24 ? parsedHour : 0; |
References
- Validate manually parsed numeric values before using them as array indices to prevent out-of-bounds access and data corruption.
1 participant
Extracted topic and language aggregation loops into their own functions (
aggregateTopicsandaggregateLanguages) to improve readability and maintainability.PR created automatically by Jules for task 16864096372775715831 started by @is0692vs
Greptile Summary
PR のメイン変更は
fetchStarredRepos内のトピック・言語集計ロジックをaggregateTopics/aggregateLanguagesという独立した関数に切り出すリファクタリングです。その他の差分はほぼすべて Prettier による整形（末尾カンマ追加、長行の折り返しなど）で、動作への影響はありません。aggregateTopics/aggregateLanguagesを抽出し、fetchStarredReposの本体をシンプルにした。ロジック自体の変更はなく、出力結果は同一。allStarredへの走査が1回から2回に増加したが、最大200件のデータ量なので実用上の影響は無視できる。Confidence Score: 4/5
ロジックの正確性は維持されており、マージして問題ないリファクタリング PR です。
変更の大部分は Prettier によるフォーマット整形で、動作への影響はありません。aggregateTopics / aggregateLanguages の抽出も出力結果は元のコードと同一です。唯一の指摘点は allStarred を2回走査するようになった点ですが、データ量が最大200件のため実害はありません。
特に問題のあるファイルはありません。src/lib/github.ts の aggregateTopics / aggregateLanguages 付近を念のため確認するとよいでしょう。
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "refactor: extract aggregation loops in f..." | Re-trigger Greptile