Skip to content

⚡ Refactor fetchActivity to use Promise.allSettled#496

Closed
is0692vs wants to merge 1 commit into
mainfrom
perf/promise-all-settled-407286656699350926
Closed

⚡ Refactor fetchActivity to use Promise.allSettled#496
is0692vs wants to merge 1 commit into
mainfrom
perf/promise-all-settled-407286656699350926

Conversation

@is0692vs

@is0692vs is0692vs commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

💡 What: Replaced the sequential for...of await loop with Promise.allSettled in fetchActivity.
🎯 Why: To resolve all pages concurrently as requested in the issue.
📊 Measured Improvement: I was unable to show a meaningful performance improvement. In fact, benchmark results showed a regression in early-break scenarios (e.g., from ~50ms to ~500ms). This happens because Promise.allSettled forces the program to wait for all pages to resolve before proceeding, effectively destroying the early-exit latency optimization that existed in the original for...of loop over pre-initiated promises.


PR created automatically by Jules for task 407286656699350926 started by @is0692vs

Greptile Summary

This PR changes activity page handling in the GitHub client.

  • fetchActivity now waits with Promise.allSettled.
  • Page results are processed after all page requests settle.
  • The old per-promise rejection logging was removed.

Confidence Score: 4/5

The changed activity fetch path should be fixed before merging.

  • Short first pages can still wait on slow later pages.
  • Non-fatal later-page failures can disappear from both logs and returned errors.
  • The change is limited to one GitHub client function.

src/lib/github.ts

Important Files Changed

Filename Overview
src/lib/github.ts fetchActivity now settles all page promises before processing results, which changes early-exit latency and removes suppressed rejection logging.

Comments Outside Diff (1)

  1. src/lib/github.ts, line 692-698 (link)

    P2 Suppressed Errors Lose Visibility

    この分岐は UserNotFoundErrorRateLimitError 以外を break で握りつぶしますが、以前は未消費ページの rejection も logger.error に記録されていました。ページ2・3で GitHub の 500、ネットワーク失敗、timeout が起きても、呼び出し元は partial activity と空の errors を受け取り、失敗原因を追えなくなります。

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: src/lib/github.ts
    Line: 692-698
    
    Comment:
    **Suppressed Errors Lose Visibility**
    
    この分岐は `UserNotFoundError``RateLimitError` 以外を `break` で握りつぶしますが、以前は未消費ページの rejection も `logger.error` に記録されていました。ページ2・3で GitHub の 500、ネットワーク失敗、timeout が起きても、呼び出し元は partial activity と空の `errors` を受け取り、失敗原因を追えなくなります。
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
src/lib/github.ts:684
**Early Exit Waits For Slow Pages**

ページ1が `100` 件未満なら activity はそこで確定しますが、`Promise.allSettled(promises)` はページ2・3の GitHub API 呼び出しが終わるまで処理を始めません。後続ページが遅い、またはランタイムの fetch timeout まで待つ場合、`fetchUserSummary``/api/dashboard/summary` は不要な tail latency に引きずられます。

### Issue 2 of 2
src/lib/github.ts:692-698
**Suppressed Errors Lose Visibility**

この分岐は `UserNotFoundError``RateLimitError` 以外を `break` で握りつぶしますが、以前は未消費ページの rejection も `logger.error` に記録されていました。ページ2・3で GitHub の 500、ネットワーク失敗、timeout が起きても、呼び出し元は partial activity と空の `errors` を受け取り、失敗原因を追えなくなります。

Reviews (1): Last reviewed commit: "perf: refactor fetchActivity to use Prom..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
github-user-summary Ignored Ignored Jul 17, 2026 6:48am

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@is0692vs, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ee315037-f106-4de0-9775-d4b30c881a13

📥 Commits

Reviewing files that changed from the base of the PR and between 0a9a1e0 and 6e00a5a.

📒 Files selected for processing (1)
  • src/lib/github.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/promise-all-settled-407286656699350926

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread src/lib/github.ts
for (const p of promises) {
try {
const events = await p;
const results = await Promise.allSettled(promises);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Early Exit Waits For Slow Pages

ページ1が 100 件未満なら activity はそこで確定しますが、Promise.allSettled(promises) はページ2・3の GitHub API 呼び出しが終わるまで処理を始めません。後続ページが遅い、またはランタイムの fetch timeout まで待つ場合、fetchUserSummary/api/dashboard/summary は不要な tail latency に引きずられます。

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/lib/github.ts
Line: 684

Comment:
**Early Exit Waits For Slow Pages**

ページ1が `100` 件未満なら activity はそこで確定しますが、`Promise.allSettled(promises)` はページ2・3の GitHub API 呼び出しが終わるまで処理を始めません。後続ページが遅い、またはランタイムの fetch timeout まで待つ場合、`fetchUserSummary``/api/dashboard/summary` は不要な tail latency に引きずられます。

How can I resolve this? If you propose a fix, please make it concise.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@is0692vs

Copy link
Copy Markdown
Contributor Author

Closing this nonessential behavior-changing concurrency refactor; Promise.allSettled changes failure semantics and the 4/5 review still reports unresolved risk.

@is0692vs is0692vs closed this Jul 18, 2026
@is0692vs
is0692vs deleted the perf/promise-all-settled-407286656699350926 branch July 18, 2026 08:59
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing this nonessential behavior-changing concurrency refactor; Promise.allSettled changes failure semantics and the 4/5 review still reports unresolved risk.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant