test(tui): relax yolo ask-rule event timeout on windows#3644
Merged
Conversation
The model-driven YOLO ask-rule regression test can exceed ten seconds under the Windows full-suite runner before the relevant engine event arrives. Keep the behavior assertion intact but give model-turn event waits a Windows-sized timeout so the release lane does not go red from runner slowness.
|
Claude finished @Hmbown's task in 46s —— View job Review
Summary: Straightforward and correct. The change extracts a Correctness — no issues found
Placement — fine The helper sits between Reuse — nothing to consolidate Only two call sites exist and they're both updated. No dead code introduced. Verdict: Ready to merge as-is. Good minimal fix for the Windows CI regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation