docs(contributing): fix stale file paths in PR exemplars#3684
Conversation
Harvested from PR #3680 by @findshan. The Shape of a Typical PR section pointed to paths that have since moved or were missing the crate prefix: - #386 /init: crates/tui/src/commands/init.rs -> crates/tui/src/commands/groups/project/init.rs - #389 LSP: core/engine/lsp_hooks.rs -> crates/tui/src/core/engine/lsp_hooks.rs - #393 /share: crates/tui/src/commands/share.rs -> crates/tui/src/commands/groups/project/share.rs Verified each path against the current tree. The crates/tui/src/lsp/ and crates/cli/src/update.rs references in the same block are already correct and were left unchanged. Signed-off-by: findshan <dengwenshan123456@outlook.com>
|
Claude finished @Hmbown's task in 45s —— View job PR Review: docs(contributing): fix stale file paths in PR exemplars
SummaryDocs-only change, three path corrections in the "Shape of a Typical PR" exemplar block in
The two paths left unchanged ( Commit / Credit Hygiene
VerdictNo issues found. The diff is minimal, factually correct, and contributor credit is properly preserved. Ready to merge. |
|
Claude finished @Hmbown's task in 41s —— View job
PR Review: docs(contributing): fix stale file paths in PR exemplarsDocs-only change — three path corrections in the "Shape of a Typical PR" exemplar block in Path Verification
Unchanged paths ( Commit / Credit Hygiene
VerdictNo issues. The diff is minimal, factually correct, and contributor credit is properly preserved. Ready to merge. |
|
Re-tried this today during the 0.8.66 PR sweep. The diff is still clean, the check set and credit hygiene are still good, and this remains the preferred landing path for #3680 because it preserves @findshan's contribution cleanly. GitHub still blocks a normal merge with branch policy, and |
|
Claude finished @Hmbown's task in 46s —— View job
PR Review: docs(contributing): fix stale file paths in PR exemplarsDocs-only change — three path corrections in the "Shape of a Typical PR" exemplar block in Path Verification
Unchanged paths ( Commit / Credit Hygiene
VerdictNo issues. The diff is minimal, factually correct, and contributor credit is properly preserved. Ready to merge. |
Summary
Harvests #3680 by @findshan into a maintainer branch so the docs-only cleanup can land with contributor credit preserved.
Supersedes #3680 after this lands.
Credit
Original PR: #3680 by @findshan. The harvested commit is authored as Wenshan Deng using the canonical GitHub noreply identity 224246733+findshan@users.noreply.github.com and includes Harvested from PR #3680 by @findshan.
Local Verification