fix(tui): show hunt verdicts in tasks#3716
Merged
Merged
Conversation
Signed-off-by: cyq <15000851237@163.com>
Signed-off-by: cyq <15000851237@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2093
Problem
run_verifiersexposes the hunt verdict in its JSON output, but durable task summaries did not retain that verdict, so/task listcould not show the requested verdict glyph.Change
verifier_verdict,hunt_verdict, andgoal_statusmetadata to synchronousrun_verifiersresultstask_updates.hunt_verdicton durable tasks and expose it throughTaskSummaryVerdictglyph column in/task listonly when a listed task has a hunt verdictVerification
cargo fmt --all --checkcargo test -p codewhale-tui task_list_ --lockedcargo test -p codewhale-tui record_tool_metadata_updates --lockedcargo test -p codewhale-tui run_verifiers_emits_hunt_verdict_mapping --locked