Conversation
…ommon 1.0.3
Breaking-free modernization via deprecation shims throughout:
- T1-1: define and call set_FFTPROD (was exported but undefined against dev
RegisterMismatchCommon 1.0.2+); also export FFTPROD ref directly (T2-6)
- T1-2: rename allow_inner_threading! → set_inner_threading!; name implied
one-way permission grant rather than a toggle (deprecation shim added)
- T2-1: export mismatch_zeroshift and checksamesize so deprecated callers who
update their code find the replacement in scope
- T2-2: export non-mutating correctbias and truncatenoise alongside the !
variants (were accessible but not in the explicit export list)
- T2-3: export set_inner_threading! and inner_threading
- T2-4: CMStorage{T}(undef, width, shift) now accepts AbstractVector for both
arguments, matching the DimsLike/WidthLike convention of the high-level API
- T2-5: import and export highpass! from RegisterCore alongside highpass
- T3-2: internal call updated from checksize_maxshift → checksizemaxshift
- T3-4: internal call updated from each_point → each_aperture_center
- Update tests to use new names (removes deprecation noise from test output)
- Pin RegisterMismatchCommon ≥ 1.0.3
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 118 123 +5
=========================================
+ Hits 118 123 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_FFTPRODwas exported but undefined against RegisterMismatchCommon ≥ 1.0.2; now resolves correctly;FFTPRODref also exported directlyallow_inner_threading!→set_inner_threading!(old name implied a one-way permission grant rather than a toggle); deprecation shim keeps existing callers workingmismatch_zeroshiftandchecksamesizenow explicitly exported so callers who act on deprecation warnings find the replacement in scopecorrectbiasandtruncatenoisenow explicitly exported alongside their!variantsset_inner_threading!andinner_threadingnow exportedCMStorage{T}(undef, width, shift)now acceptsAbstractVectorfor both arguments, consistent with theDimsLike/WidthLikeconvention used in the high-level APIhighpass!imported from RegisterCore and exported alongsidehighpassFFTPRODref exported directlychecksizemaxshift,each_aperture_center)set_FFTPROD,each_aperture_center,checksizemaxshift)All changes are non-breaking — deprecated names remain functional via
Base.@deprecateshims.Test plan
Pkg.test("RegisterMismatch")passes (203 tests, zero deprecation warnings)🤖 Generated with Claude Code