Conversation
…s! args (v1.0.1)
- CuRCpair(A): Array{T} → AbstractArray{T} so views/subarrays are accepted
- CMStorage display-compat constructors: T <: Real → T <: AbstractFloat for early error detection
- mismatch_apertures!: add type annotations; move cms to position 2 (consistent with
mismatch!(mm, cms, moving)); deprecation shim retained for old argument order
- Bump version to 1.0.1
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
….0.2
- Revert CMStorage display-compat constructors back to T <: Real: the T <: Real
bound is load-bearing — it creates distinct methods from the T <: AbstractFloat
primary constructors, enabling keyword-based dispatch for the display= arg
- Update tests: indmin_mismatch → argmin_mismatch (renamed in RegisterCore v1.0.2)
- Add test for CMStorage{T,N} two-type-parameter display-compat constructor
- Add test for mismatch_apertures! deprecation shim (old argument order)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
=========================================
- Coverage 0.52% 0.00% -0.53%
=========================================
Files 2 2
Lines 192 194 +2
=========================================
- Hits 1 0 -1
- Misses 191 194 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CuRCpairconstructor:Array{T}→AbstractArray{T}, so views and other array wrappers are acceptedmismatch_apertures!arguments:cmsmoves to position 2 (matchingmismatch!(mm, cms, moving)); deprecation shim retained for the old order withBase.depwarnmismatch_apertures!:AbstractArray{<:MismatchArray},CMStorage,CuArray,CuArray,AbstractArray— gives callers better error messagesindmin_mismatch→argmin_mismatchCMStorage{T,N}display-compat constructor;mismatch_apertures!deprecation shimNotes
The
CMStoragedisplay-compat constructors retainT <: Real(notAbstractFloat) — this is intentional. The looser bound is what creates distinct methods from the primary constructors, enabling Julia's keyword dispatch to routedisplay=falsecalls there correctly.Test plan
Pkg.test())🤖 Generated with Claude Code