Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ai/memory.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
- `BrewTests` = unit tests
- `BrewUITests` = UI tests
- Repository root folder remains `BrewUI` (part of a larger parent project layout).
- App bundle/package identifier remains unchanged for compatibility (`sh.brew.BrewUI`), while test bundle identifiers were updated to match renamed targets (`sh.brew.BrewTests` and `sh.brew.BrewUITests`).
- App bundle identifier and installer package identifier changed to `sh.brew.app` (was `sh.brew.BrewUI`). Test bundle identifiers track renamed targets (`sh.brew.BrewTests` and `sh.brew.BrewUITests`).

## 2026-03-15 — Actionlint Policy-Compliant Pattern

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pr_build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
- "Brew/**"
- "BrewTests/**"
- "BrewUITests/**"
- "Brew.xcodeproj/**"
- "Homebrew.xcodeproj/**"
- "Brew.entitlements"
- "Sources/**"
- "Tests/**"
Expand All @@ -22,7 +22,7 @@ on:
- "Brew/**"
- "BrewTests/**"
- "BrewUITests/**"
- "Brew.xcodeproj/**"
- "Homebrew.xcodeproj/**"
- "Brew.entitlements"
- "Sources/**"
- "Tests/**"
Expand All @@ -48,13 +48,13 @@ jobs:
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3

- name: Resolve package dependencies
run: xcodebuild -resolvePackageDependencies -project Brew.xcodeproj
run: xcodebuild -resolvePackageDependencies -project Homebrew.xcodeproj

- name: Build and test (Xcode app target)
run: |
set -o pipefail
xcodebuild test \
-project Brew.xcodeproj \
-project Homebrew.xcodeproj \
-scheme Brew-Unit \
-destination "platform=macOS" \
-skipPackagePluginValidation \
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
- name: Build and archive
run: |
xcodebuild archive \
-project Brew.xcodeproj \
-project Homebrew.xcodeproj \
-scheme Brew \
-configuration Release \
-archivePath "$RUNNER_TEMP/Brew.xcarchive" \
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
echo "VERSION=$VERSION" >> "$GITHUB_ENV"
pkgbuild \
--root "$RUNNER_TEMP/export" \
--identifier "sh.brew.BrewUI" \
--identifier "sh.brew.app" \
--version "$VERSION" \
--install-location "/Applications" \
--scripts scripts \
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ui_smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3

- name: Resolve package dependencies
run: xcodebuild -resolvePackageDependencies -project Brew.xcodeproj
run: xcodebuild -resolvePackageDependencies -project Homebrew.xcodeproj

- name: Run UI smoke test
run: |
Expand All @@ -53,7 +53,7 @@ jobs:

XCODEBUILD_ARGS=(
test
-project Brew.xcodeproj
-project Homebrew.xcodeproj
-scheme Brew-UI
-destination "platform=macOS"
-skipPackagePluginValidation
Expand Down
2 changes: 1 addition & 1 deletion Brew-UI.xctestplan
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"testTargets" : [
{
"target" : {
"containerPath" : "container:Brew.xcodeproj",
"containerPath" : "container:Homebrew.xcodeproj",
"identifier" : "EEC39ED52F5AB4B900269514",
"name" : "BrewUITests"
}
Expand Down
2 changes: 1 addition & 1 deletion Brew-Unit.xctestplan
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"testTargets" : [
{
"target" : {
"containerPath" : "container:Brew.xcodeproj",
"containerPath" : "container:Homebrew.xcodeproj",
"identifier" : "EEC39ECB2F5AB4B900269514",
"name" : "BrewTests"
}
Expand Down
58 changes: 0 additions & 58 deletions Brew/Assets.xcassets/AppIcon.appiconset/Contents.json

This file was deleted.

4 changes: 3 additions & 1 deletion BrewTests/.swiftlint.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Merge with repo root `.swiftlint.yml`. Integration/UI test scaffolding often grows beyond
# the default struct type-body cap without adding real complexity.
# the default type-body and file caps without adding real complexity, so test files
# and test types are allowed to be any length.
parent_config: ../.swiftlint.yml

disabled_rules:
- type_body_length
- file_length
1 change: 1 addition & 0 deletions BrewUITests/.swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ parent_config: ../.swiftlint.yml

disabled_rules:
- type_body_length
- file_length
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@
EE00AA000000000000000002 /* Signing.local.xcconfig.example */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = Signing.local.xcconfig.example; sourceTree = "<group>"; };
EE2FB0352F653F89004AE92A /* Brew-Unit.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = "Brew-Unit.xctestplan"; sourceTree = "<group>"; };
EE2FB0372F654024004AE92A /* Brew-UI.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = "Brew-UI.xctestplan"; sourceTree = "<group>"; };
EEC39EBF2F5AB4B900269514 /* Brew.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Brew.app; sourceTree = BUILT_PRODUCTS_DIR; };
EEC39EBF2F5AB4B900269514 /* Homebrew.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Homebrew.app; sourceTree = BUILT_PRODUCTS_DIR; };
EEC39ECC2F5AB4B900269514 /* BrewTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BrewTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
EEC39ED62F5AB4B900269514 /* BrewUITests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = BrewUITests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
/* End PBXFileReference section */

/* Begin PBXFileSystemSynchronizedRootGroup section */
EEC39EC12F5AB4B900269514 /* Brew */ = {
EEC39EC12F5AB4B900269514 /* Homebrew */ = {
isa = PBXFileSystemSynchronizedRootGroup;
path = Brew;
path = Homebrew;
sourceTree = "<group>";
};
EEC39ECF2F5AB4B900269514 /* BrewTests */ = {
Expand Down Expand Up @@ -119,7 +119,7 @@
children = (
EE2FB0352F653F89004AE92A /* Brew-Unit.xctestplan */,
EE2FB0372F654024004AE92A /* Brew-UI.xctestplan */,
EEC39EC12F5AB4B900269514 /* Brew */,
EEC39EC12F5AB4B900269514 /* Homebrew */,
EEC39ECF2F5AB4B900269514 /* BrewTests */,
EEC39ED92F5AB4B900269514 /* BrewUITests */,
EEC39EC02F5AB4B900269514 /* Products */,
Expand All @@ -130,7 +130,7 @@
EEC39EC02F5AB4B900269514 /* Products */ = {
isa = PBXGroup;
children = (
EEC39EBF2F5AB4B900269514 /* Brew.app */,
EEC39EBF2F5AB4B900269514 /* Homebrew.app */,
EEC39ECC2F5AB4B900269514 /* BrewTests.xctest */,
EEC39ED62F5AB4B900269514 /* BrewUITests.xctest */,
);
Expand All @@ -140,9 +140,9 @@
/* End PBXGroup section */

/* Begin PBXNativeTarget section */
EEC39EBE2F5AB4B900269514 /* Brew */ = {
EEC39EBE2F5AB4B900269514 /* Homebrew */ = {
isa = PBXNativeTarget;
buildConfigurationList = EEC39EE02F5AB4B900269514 /* Build configuration list for PBXNativeTarget "Brew" */;
buildConfigurationList = EEC39EE02F5AB4B900269514 /* Build configuration list for PBXNativeTarget "Homebrew" */;
buildPhases = (
EEC39EBB2F5AB4B900269514 /* Sources */,
EEC39EBC2F5AB4B900269514 /* Frameworks */,
Expand All @@ -154,9 +154,9 @@
EEAA00012F70000000000003 /* PBXTargetDependency */,
);
fileSystemSynchronizedGroups = (
EEC39EC12F5AB4B900269514 /* Brew */,
EEC39EC12F5AB4B900269514 /* Homebrew */,
);
name = Brew;
name = Homebrew;
packageProductDependencies = (
EEAA100100000000000000C1 /* BrewCore */,
EEAA100200000000000000C2 /* BrewUIComponents */,
Expand All @@ -172,7 +172,7 @@
EEAA100C00000000000000CC /* BrewFeatureConfig */,
);
productName = Brew;
productReference = EEC39EBF2F5AB4B900269514 /* Brew.app */;
productReference = EEC39EBF2F5AB4B900269514 /* Homebrew.app */;
productType = "com.apple.product-type.application";
};
EEC39ECB2F5AB4B900269514 /* BrewTests */ = {
Expand Down Expand Up @@ -244,7 +244,7 @@
};
};
};
buildConfigurationList = EEC39EBA2F5AB4B900269514 /* Build configuration list for PBXProject "Brew" */;
buildConfigurationList = EEC39EBA2F5AB4B900269514 /* Build configuration list for PBXProject "Homebrew" */;
developmentRegion = en;
hasScannedForEncodings = 0;
knownRegions = (
Expand All @@ -262,7 +262,7 @@
projectDirPath = "";
projectRoot = "";
targets = (
EEC39EBE2F5AB4B900269514 /* Brew */,
EEC39EBE2F5AB4B900269514 /* Homebrew */,
EEC39ECB2F5AB4B900269514 /* BrewTests */,
EEC39ED52F5AB4B900269514 /* BrewUITests */,
);
Expand Down Expand Up @@ -326,12 +326,12 @@
};
EEC39ECE2F5AB4B900269514 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = EEC39EBE2F5AB4B900269514 /* Brew */;
target = EEC39EBE2F5AB4B900269514 /* Homebrew */;
targetProxy = EEC39ECD2F5AB4B900269514 /* PBXContainerItemProxy */;
};
EEC39ED82F5AB4B900269514 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = EEC39EBE2F5AB4B900269514 /* Brew */;
target = EEC39EBE2F5AB4B900269514 /* Homebrew */;
targetProxy = EEC39ED72F5AB4B900269514 /* PBXContainerItemProxy */;
};
/* End PBXTargetDependency section */
Expand Down Expand Up @@ -482,7 +482,7 @@
"@executable_path/../Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = sh.brew.BrewUI;
PRODUCT_BUNDLE_IDENTIFIER = sh.brew.app;
PRODUCT_NAME = "$(TARGET_NAME)";
REGISTER_APP_GROUPS = YES;
STRING_CATALOG_GENERATE_SYMBOLS = YES;
Expand Down Expand Up @@ -513,7 +513,7 @@
"@executable_path/../Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = sh.brew.BrewUI;
PRODUCT_BUNDLE_IDENTIFIER = sh.brew.app;
PRODUCT_NAME = "$(TARGET_NAME)";
REGISTER_APP_GROUPS = YES;
STRING_CATALOG_GENERATE_SYMBOLS = YES;
Expand Down Expand Up @@ -604,7 +604,7 @@
/* End XCBuildConfiguration section */

/* Begin XCConfigurationList section */
EEC39EBA2F5AB4B900269514 /* Build configuration list for PBXProject "Brew" */ = {
EEC39EBA2F5AB4B900269514 /* Build configuration list for PBXProject "Homebrew" */ = {
isa = XCConfigurationList;
buildConfigurations = (
EEC39EDE2F5AB4B900269514 /* Debug */,
Expand All @@ -613,7 +613,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
EEC39EE02F5AB4B900269514 /* Build configuration list for PBXNativeTarget "Brew" */ = {
EEC39EE02F5AB4B900269514 /* Build configuration list for PBXNativeTarget "Homebrew" */ = {
isa = XCConfigurationList;
buildConfigurations = (
EEC39EE12F5AB4B900269514 /* Debug */,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "EEC39EBE2F5AB4B900269514"
BuildableName = "Brew.app"
BlueprintName = "Brew"
ReferencedContainer = "container:Brew.xcodeproj">
BuildableName = "Homebrew.app"
BlueprintName = "Homebrew"
ReferencedContainer = "container:Homebrew.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
Expand Down Expand Up @@ -50,9 +50,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "EEC39EBE2F5AB4B900269514"
BuildableName = "Brew.app"
BlueprintName = "Brew"
ReferencedContainer = "container:Brew.xcodeproj">
BuildableName = "Homebrew.app"
BlueprintName = "Homebrew"
ReferencedContainer = "container:Homebrew.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</LaunchAction>
Expand All @@ -67,9 +67,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "EEC39EBE2F5AB4B900269514"
BuildableName = "Brew.app"
BlueprintName = "Brew"
ReferencedContainer = "container:Brew.xcodeproj">
BuildableName = "Homebrew.app"
BlueprintName = "Homebrew"
ReferencedContainer = "container:Homebrew.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</ProfileAction>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "EEC39EBE2F5AB4B900269514"
BuildableName = "Brew.app"
BlueprintName = "Brew"
ReferencedContainer = "container:Brew.xcodeproj">
BuildableName = "Homebrew.app"
BlueprintName = "Homebrew"
ReferencedContainer = "container:Homebrew.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
Expand Down Expand Up @@ -50,9 +50,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "EEC39EBE2F5AB4B900269514"
BuildableName = "Brew.app"
BlueprintName = "Brew"
ReferencedContainer = "container:Brew.xcodeproj">
BuildableName = "Homebrew.app"
BlueprintName = "Homebrew"
ReferencedContainer = "container:Homebrew.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</LaunchAction>
Expand All @@ -67,9 +67,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "EEC39EBE2F5AB4B900269514"
BuildableName = "Brew.app"
BlueprintName = "Brew"
ReferencedContainer = "container:Brew.xcodeproj">
BuildableName = "Homebrew.app"
BlueprintName = "Homebrew"
ReferencedContainer = "container:Homebrew.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</ProfileAction>
Expand Down
Loading
Loading