feat: ship ScratchNode public wiki loop#488
Closed
HomenShum wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
05b8a63 to
3f3dd31
Compare
Owner
Author
|
Superseded by #490 on CI-compliant branch feat/scratchnode-public-wiki-loop. |
✅ Dogfood Visual QA Gate: PASSED
ArtifactsDownload the Generated by Dogfood QA Gate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
scratchnode.live/e/:slug/wiki.events:getPublishedWikiBySlug({ slug })so the public route can read the latest published wiki by slug or room code without exposing drafts/private notes.Sharebuttons to copy real addressable answer URLs instead of only showing a toast.Verification
npx vitest run convex/__tests__/scratchnode.publicWikiRead.test.tsnpx playwright test tests/e2e/scratchnode-live-route-honesty.spec.ts --project=chromium --workers=1npx tsc --noEmit --pretty falsenpm run buildhttp://127.0.0.1:5198/proto/home-v5.htmlloaded with no console errors.Notes
This branch includes the coordination-audit commit from #484 and then closes the two highest-leverage gaps from that audit: public wiki payoff and honest answer sharing.