Skip to content

fix(schema): allow spreadsheetEvents.operation row_delta to unblock prod Convex deploy#502

Closed
HomenShum wants to merge 1 commit into
mainfrom
fix/schema-spreadsheet-row-delta
Closed

fix(schema): allow spreadsheetEvents.operation row_delta to unblock prod Convex deploy#502
HomenShum wants to merge 1 commit into
mainfrom
fix/schema-spreadsheet-row-delta

Conversation

@HomenShum
Copy link
Copy Markdown
Owner

P0 — production deploys broken since ~18:37 UTC

vercel-build.sh runs convex deploy on every production build. It has been failing schema validation:

Schema validation failed. Document in table spreadsheetEvents does not match: Path: .operation
Value: "row_delta"
Validator: v.union(set_cell, insert_row, delete_row, add_column, delete_column, apply_formula, add_sheet, rename_sheet)
Error: Command "bash scripts/vercel-build.sh" exited with 1

The live CDN is serving bytes from the last successful deploy (Last-Modified 18:37, ~3.7h stale). Everything merged since 18:37 — #496, #497, #500 (host-write security), #501, #499 (type-scale) — is NOT live.

Root cause

row_delta is a legitimate operation introduced by PR #498 (spreadsheets.ts applyRowDelta + schema literal + test). That feature was run against shared prod Convex out-of-band (the AGENT_COORDINATION hazard), writing a spreadsheetEvents doc with operation: "row_delta" — but #498's schema addition never reached main, so main's validator rejects the doc and blocks all deploys.

Fix

Forward-port the exact literal #498 adds: v.literal("row_delta") into main's union. Additive / expand pattern — non-destructive, reversible, zero conflict when #498 merges (same line). Direct precedent: #477 'tolerate lastActivityAt'.

Verification plan

  • CI green (preview Convex deployment has no stray doc, so it always passed — which is why this slipped past CI).
  • Real proof: the post-merge production Convex deploy validates the stray doc and succeeds → live URL flips to the new bytes. I'll live-DOM verify after merge.

Follow-ups (flagged, not in this PR)

🤖 Generated with Claude Code

…rod Convex deploy

Production Vercel deploys have errored since ~18:37 UTC: vercel-build.sh runs convex deploy, which fails schema validation — a spreadsheetEvents doc in shared prod has operation 'row_delta', not in the union. Root cause: PR #498's applyRowDelta feature (which DOES add this literal + emitting code + test) was run against shared prod Convex out-of-band before its schema change merged (the AGENT_COORDINATION out-of-band-write hazard). Every queued deploy since (incl. #496/#497/#500/#501/#499) is blocked, so nothing merged since 18:37 is live.

Forward-port the exact literal #498 adds (v.literal('row_delta')) into main's union so prod data validates. Additive/expand pattern — non-destructive, reversible, no conflict when #498 merges (same line). Precedent: #477 'tolerate lastActivityAt'.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodebench-ai Ready Ready Preview, Comment Jun 3, 2026 10:27pm

Request Review

@HomenShum HomenShum enabled auto-merge (squash) June 3, 2026 22:26
@HomenShum HomenShum closed this Jun 3, 2026
auto-merge was automatically disabled June 3, 2026 22:32

Pull request was closed

@HomenShum HomenShum deleted the fix/schema-spreadsheet-row-delta branch June 3, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants