fix(schema): allow spreadsheetEvents.operation row_delta to unblock prod deploys#505
Merged
Conversation
…rod deploys P0: production deploy pipeline down ~6h. scripts/vercel-build.sh runs convex deploy --typecheck=enable (fail-closed) before the build; it fails schema-vs-data validation because a shared-prod spreadsheetEvents doc carries operation 'row_delta', not in the 8-literal union. row_delta appears nowhere in main source (git grep = 0) — stale data written out-of-band from the unmerged applyRowDelta feature (8e58a26). Additive expand makes the stray doc valid without mutating prod data: backfill-safe, reversible. Founder-approved (Option A). Re-cut of closed-unmerged #502. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 — production deploy pipeline down ~6h (founder-approved Option A)
scripts/vercel-build.shrunsconvex deploy --typecheck=enable(fail-closed,set -euo pipefail) before the build. It fails schema-vs-data validation because a shared-prodspreadsheetEventsdoc carriesoperation: "row_delta"— a value not in the 8-literal union (convex/schema.ts:4963). So every Production deploy aborts; ~6h of merged work (incl. #500 host-write security, #499 type-scale) is NOT live (12 consecutive prod deploys ● Error).row_deltaappears nowhere in main source (git grep = 0) — it's stale data written out-of-band from the unmergedapplyRowDeltafeature (8e58a265), an inverted expand-contract (writer reached prod before reader reached main).Fix
Additive
v.literal("row_delta")expand. Backfill-safe (the stray doc becomes valid with no prod-data mutation), reversible. This is the re-cut of closed-unmerged #502 the NodeBench audit recommended, now founder-approved.After merge
Prod
convex deployvalidates → the deploy pipeline flips ● Ready and the ~6h backlog ships. I'll live-verify prod recovers.Follow-ups (not in this PR — tracked from the audit)
storeSpreadsheetEvent'sv.any()seam so the class can't recur.convex deploy --dry-runschema-vs-data gate so this fails a PR, not prod.🤖 Generated with Claude Code