Merged
Conversation
At some point, we may wish to implement specific matching for errors, because tests often should fail on a specific error. But anything is better than nothing, and once this is done we can always grep for //? to find all the tests to change later. (Or, of course, they will just fail if we implement extra stuff that they have to do, so we will just have to update them at that time).
The if_extra_parens test really should succeed, so we should probably just fix that asap. It's much easier than e.g. fixing errTODO_bad_order.
These tests were previously not run due to not being in a subdirectory.
Any tests that just test a program that should compile are fine enough to run. I've marked all the ones in the classes folder that are like this as noout, but I'm not sure how necessary that is.
This is slightly more informative (e.g. now err_weird_var is failing) but also more fragile. But, should be fine for now.
This makes writing the err_fun_missing_brace test possible.
I also implemented a few new tests for these.
This still doesn't seem to let the typechecker find the correct types for these.
This reverts commit 19ae520.
So now every time we promote something inside typecheck we need to do it through self.promote() rather than expr.promote(). This is necessary so that bottom types get promoted as if they were unassigned.
This helps us narrow down the error in err_weird_var.
Before, the "no scope matches" case simply didn't report an error. Now it does. This allows us to fix err_weird_var.
Until such time as we move all the tests to one folder (if we ever decide to do that), this will at least make it easier to track down failing tests by alphabetical order and so forth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does the following: