iPhone 6 and 6+, add raw string to unknown#3
Open
nap-sam-dean wants to merge 2 commits intoHorse888:masterfrom
Open
iPhone 6 and 6+, add raw string to unknown#3nap-sam-dean wants to merge 2 commits intoHorse888:masterfrom
nap-sam-dean wants to merge 2 commits intoHorse888:masterfrom
Conversation
…devices without needing an app store update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey.
Instead of just
@"Unknown"it seems a bit more useful to have something like@"Unknown - iPhone8,1"as the human readable name. That way if you are using this for analytics (like I am) you can see all the devices, even if this library doesn't know what they are yet.I've also included Heiko's commit for iphone 6 and 6+ - this is a cherry-pick of his commit so it shouldn't conflict with anything else he's done or a pull request from him :)
Let me know what you think,
Sam