Skip to content

🎨 Palette: Lobby Accessibility Improvements#16

Open
Horus0305 wants to merge 1 commit intomainfrom
palette-lobby-accessibility-17837810380956951633
Open

🎨 Palette: Lobby Accessibility Improvements#16
Horus0305 wants to merge 1 commit intomainfrom
palette-lobby-accessibility-17837810380956951633

Conversation

@Horus0305
Copy link
Copy Markdown
Owner

💡 What: Added ARIA labels, tooltips, and focus styles to icon-only buttons in the Lobby component.
🎯 Why: To improve accessibility for screen reader users and keyboard navigation, and provide better visual feedback for mouse users.
📸 Before/After: Visual changes are subtle (focus rings and tooltips on hover), but the accessibility tree is significantly improved.
♿ Accessibility:
- Added meaningful aria-labels to "A", "B", "👑", and "Remove CPU" buttons.
- Enhanced keyboard focus visibility with focus-visible ring styles.


PR created automatically by Jules for task 17837810380956951633 started by @Horus0305

- Add `aria-label` and `title` to "Assign Team" buttons.
- Add `aria-label` and `title` to "Make Captain" button.
- Add `aria-label` to "Remove CPU" button.
- Add `focus-visible` styles to these buttons for better keyboard navigation.

Co-authored-by: Horus0305 <98160215+Horus0305@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings February 21, 2026 17:20
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
very-important-study-material Ready Ready Preview, Comment Feb 21, 2026 5:20pm

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the Lobby UI’s accessibility by adding clearer accessible names and better keyboard focus visibility for small/icon-style action buttons used during team assignment and captain selection.

Changes:

  • Added aria-label and title attributes to team assignment (A/B) and captain (👑) buttons.
  • Added focus-visible ring styles to improve keyboard focus indication for those buttons.
  • Updated package-lock.json with removal of "peer": true markers across many entries.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
CricketGame/frontend/src/components/Lobby.tsx Adds ARIA labels/tooltips and focus-visible styles to improve accessibility of small action buttons in the lobby UI.
CricketGame/frontend/package-lock.json Lockfile formatting/metadata changes (removal of "peer": true flags) unrelated to the stated accessibility goal.
Files not reviewed (1)
  • CricketGame/frontend/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

CricketGame/frontend/src/components/Lobby.tsx:372

  • aria-label on a button that already has visible text (“Remove CPU”) will override the accessible name and can create a mismatch between what sighted users see and what screen readers announce. Consider removing aria-label here, or change the visible button text to match the more descriptive label (or use aria-describedby for extra context).
                                            onClick={() => sendMsg({ action: 'REMOVE_CPU' })}
                                            aria-label="Remove the last added CPU player"
                                            disabled={cpuCount === 0}
                                            className="px-4 py-2 bg-white border border-slate-200 text-slate-400 text-xs font-bold uppercase tracking-wider rounded disabled:opacity-50 disabled:cursor-not-allowed"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 89 to 96
"node_modules/@babel/core": {
"version": "7.29.0",
"resolved": "https://registry.npmjs.org/@babel/core/-/core-7.29.0.tgz",
"integrity": "sha512-CGOfOJqWjg2qW/Mb6zNsDm+u5vFQ8DxXfbM09z69p5Z6+mE1ikP2jUXw+j42Pf1XTYED2Rni5f95npYeuwMDQA==",
"dev": true,
"license": "MIT",
"peer": true,
"dependencies": {
"@babel/code-frame": "^7.29.0",
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes package-lock.json (e.g., removing the "peer": true markers) without any corresponding dependency changes. Since this is unrelated to the Lobby accessibility updates, it will add noise/merge conflicts and may affect reproducibility depending on the npm version—recommend reverting the lockfile changes or documenting/regenerating them intentionally in a dedicated dependency PR.

Copilot uses AI. Check for mistakes.
Copilot AI added a commit that referenced this pull request Feb 21, 2026
Co-authored-by: Horus0305 <98160215+Horus0305@users.noreply.github.com>
Horus0305 added a commit that referenced this pull request Feb 21, 2026
Merge PRs #14, #15, #16: auth fix, async CPU moves, lobby a11y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants