fix: prevent crash when entry.cost becomes undefined between Show condition and render - #13
Merged
Merged
Conversation
…dition and render SolidJS Show's `when` condition and child render can be separated by a reactive tick. If entry.cost transitions from a number to undefined between the guard check and the child function executing, `entry.cost!.toFixed(4)` throws "undefined is not an object". Capturing the value in an IIFE closes the race window.
…dition and render SolidJS Show's `when` condition and child render can be separated by a reactive tick. If entry.cost transitions from a number to undefined between the guard check and the child function executing, `entry.cost!.toFixed(4)` throws \"undefined is not an object\". Capturing the value in an IIFE closes the race window.
…dition and render SolidJS Show's `when` condition and child render can be separated by a reactive tick. If entry.cost transitions from a number to undefined between the guard check and the child function executing, `entry.cost!.toFixed(4)` throws "undefined is not an object". Capturing the value in an IIFE closes the race window.
Owner
|
Thanks for the fix. I'll merge the PR and push an update soon. Appreciate your support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entry.cost.toFixed(4)throws "undefined is not an object" whenentry.costbecomesundefinedbetween theShowcondition check and the child renderShowchildren in an IIFE to captureentry.costin a local variable, closing the reactive race windowProblem
SolidJS
Showcomponent'swhencondition and child render can be separated by a reactive tick. Ifentry.costtransitions from a number toundefinedbetween the guard check and the child function executing,entry.cost!.toFixed(4)throws becauseentry.costis nowundefined.Solution
Capture
entry.costin a localconstinside an IIFE within theShowchildren. This ensures the value is snapshotted at render time, preventing the race condition.Test plan
entry.costchanges from a number toundefinedduring reactive updatesentry.costhas a valid value🤖 Generated with Claude Code