Add delta OR set implementation#2
Open
OleksandrMizov wants to merge 2 commits intoHowProgrammingWorks:masterfrom
Open
Add delta OR set implementation#2OleksandrMizov wants to merge 2 commits intoHowProgrammingWorks:masterfrom
OleksandrMizov wants to merge 2 commits intoHowProgrammingWorks:masterfrom
Conversation
belochub
reviewed
Jan 20, 2026
DeltaBased/2-or-set.js
Outdated
| } | ||
|
|
||
| remove(item) { | ||
| const result = init(); |
Member
There was a problem hiding this comment.
Could be better to return the new instance of this class (or another one) instead of a plain object
belochub
reviewed
Jan 20, 2026
DeltaBased/2-or-set.js
Outdated
| add(item, tag = crypto.randomUUID()) { | ||
| const result = init(); | ||
| const added = this.#added[item]; | ||
| result.added[item] = added ? new Set([...added, tag]) : new Set([tag]); |
Member
There was a problem hiding this comment.
For brevity:
Suggested change
| result.added[item] = added ? new Set([...added, tag]) : new Set([tag]); | |
| result.added[item] = new Set([...(added || []), tag]); |
belochub
reviewed
Jan 20, 2026
DeltaBased/2-or-set.js
Outdated
Comment on lines
39
to
40
| for (const [item, tags] of added) { | ||
| const deltaTags = tags || new Set(); |
Member
There was a problem hiding this comment.
Can be simplified, since we always have a set there
Suggested change
| for (const [item, tags] of added) { | |
| const deltaTags = tags || new Set(); | |
| for (const [item, deltaTags] of added) { |
belochub
reviewed
Jan 20, 2026
DeltaBased/2-or-set.js
Outdated
Comment on lines
47
to
48
| const removed = Object.entries(delta.removed); | ||
| for (const [item, tags] of removed) { |
Member
There was a problem hiding this comment.
Suggested change
| const removed = Object.entries(delta.removed); | |
| for (const [item, tags] of removed) { | |
| for (const [item, tags] of Object.entries(delta.removed)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the delta OR set