Make ts optional in SlackEventSkeleton#429
Merged
jaredstehler merged 1 commit intoHubSpot:masterfrom Feb 17, 2026
Merged
Conversation
…ts without ts Many Slack event types (reaction_added, reaction_removed, pin_added, etc.) only include event_ts, not ts. Since SlackEventSkeleton is the catch-all model for ~30 unmapped event types, it should tolerate missing ts rather than throwing InvalidImmutableStateException. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jaredstehler
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SlackEventSkeletonis the catch-all model for ~30 event types without dedicated model classes. Many of these (e.g.reaction_added,reaction_removed,pin_added) don't include atsfield — onlyevent_ts. This causesInvalidImmutableStateExceptionat deserialization time.getTs()override returning null, following the same pattern used bySlackAppHomeOpenedEventIFand other event interfaces in this codebase.🤖 Generated with Claude Code