-
Notifications
You must be signed in to change notification settings - Fork 43
feat: RTL fix, diacritic popup, accessibility, PostHog proxy #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4eac22f
bb7b9ed
c4cc360
f1a108e
cd37135
4a342b8
20e32b4
71b9dca
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,3 +45,4 @@ scripts/.freq_data | |
|
|
||
| # Curation review temp files | ||
| scripts/.curation_review/ | ||
| .mcp.json | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| <template> | ||
| <div class="flex flex-col container mx-auto gap-2 w-full max-w-lg pb-2 md:pb-5 px-2"> | ||
| <div | ||
| role="group" | ||
| aria-label="Keyboard" | ||
| class="flex flex-col container mx-auto gap-2 w-full max-w-lg pb-2 md:pb-5 px-2" | ||
|
Comment on lines
+2
to
+5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Localize the keyboard group's accessible name.
🤖 Prompt for AI Agents |
||
| > | ||
| <div v-for="(row, i) in keyboard" :key="i" class="flex gap-1"> | ||
| <GameKeyboardKey | ||
| v-for="key in row" | ||
|
|
@@ -8,6 +12,7 @@ | |
| :state="game.keyClasses[key] || ''" | ||
| :hint="hints[key.toLowerCase()]?.text" | ||
| :hint-above="hints[key.toLowerCase()]?.above" | ||
| :variants="diacriticMap[key.toLowerCase()]" | ||
| @press="game.keyClick" | ||
| /> | ||
| </div> | ||
|
|
@@ -16,9 +21,12 @@ | |
|
|
||
| <script setup lang="ts"> | ||
| const game = useGameStore(); | ||
| const langStore = useLanguageStore(); | ||
|
|
||
| defineProps<{ | ||
| keyboard: string[][]; | ||
| hints: Record<string, { text: string; above?: boolean }>; | ||
| }>(); | ||
|
|
||
| const diacriticMap = computed(() => langStore.config?.diacritic_map ?? {}); | ||
| </script> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep language count consistent across README text.
Line 4 says 79 languages, but Line 11 still says 78. This creates conflicting project metadata in the same page.
Suggested fix
🤖 Prompt for AI Agents