-
Notifications
You must be signed in to change notification settings - Fork 57
chore(repo): overhaul the CI and turbo configuration #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e11491e
ci: extract the shared setup into a composite action
HugoRCD 662b289
ci: enable OIDC remote caching and rework the job graph
HugoRCD 9889e8b
build(repo): scope turbo env vars to the tasks that read them
HugoRCD 0833eb1
chore(repo): replace the per-example scripts with a single runner
HugoRCD 08e1da8
ci: report example builds without gating on them
HugoRCD d23a8be
fix(core): serialize Error instances passed to the client log.error()
HugoRCD b27a5ac
fix(repo): make the examples build, and gate CI on them
HugoRCD e0af6a4
ci: address the review on permissions and manual cache cleanup
HugoRCD d87a829
ci: build every example, with no exclusions
HugoRCD 94c0db8
Merge branch 'main' into chore/ci-overhaul
HugoRCD 6eb1217
ci: exclude eve from the example build
HugoRCD ac7273b
fix(repo): unblock the eve example and build every example in CI
HugoRCD 62b5fc5
fix(core): keep the full error payload when the client serializes an β¦
HugoRCD a44c904
ci: keep apps/telemetry out of typecheck
HugoRCD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "evlog": patch | ||
| --- | ||
|
|
||
| fix(core): serialize Error instances passed to the client `log.error()` β `name`, `message` and `stack` are non-enumerable, so an `Error` spread into a wide event contributed nothing and the call emitted an event with no error at all. The docs teach `log.error(new Error(...))` for Next.js client components, and the type only accepted a tag pair or a plain object, so the pattern failed to type check as well. Errors now land under `error` with the same shape the server logger stores, including `code`, `status`, `cause` and friends |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| name: Setup | ||
| description: Sets up pnpm and Node, then installs workspace dependencies. | ||
|
|
||
| inputs: | ||
| install: | ||
| description: Set to 'false' to skip the install step entirely. | ||
| required: false | ||
| default: 'true' | ||
| filters: | ||
| description: > | ||
| pnpm filters restricting what gets installed, e.g. "--filter=evlog...". | ||
| Empty installs the whole workspace. | ||
| required: false | ||
| default: '' | ||
| node-version: | ||
| description: Overrides the version in .node-version. | ||
| required: false | ||
| default: '' | ||
| registry-url: | ||
| description: npm registry to authenticate against, for publishing jobs. | ||
| required: false | ||
| default: '' | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # v6.0.9 | ||
|
|
||
| - uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0 | ||
| with: | ||
| node-version-file: .node-version | ||
| node-version: ${{ inputs.node-version }} | ||
| registry-url: ${{ inputs.registry-url }} | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| id: install | ||
| if: inputs.install == 'true' | ||
| # The registry flakes often enough to be worth one retry | ||
| continue-on-error: true | ||
| shell: bash | ||
| run: pnpm install --frozen-lockfile ${{ inputs.filters }} | ||
|
|
||
| - name: Install dependencies (retry) | ||
| if: inputs.install == 'true' && steps.install.outcome == 'failure' | ||
| shell: bash | ||
| run: pnpm install --frozen-lockfile ${{ inputs.filters }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.