Open
Conversation
bmielnicki
requested review from
mesutyang97,
micahcarroll and
nathan-miller23
Collaborator
|
I identified the issue loading the generated layouts, and made the fix. We still need to fix up the dependency but the branch is good to go. |
mesutyang97
approved these changes
Oct 15, 2020
Collaborator
mesutyang97
left a comment
mesutyang97
left a comment
There was a problem hiding this comment.
The Functionality is working as it should now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the possibility to pick from layouts list "complicated_random_room" and "simple_random_room".
Now when loading layout it first check if there is a .json file with mdp_gen_params inside static/layout_generation_params and if it is found use it to generate layout. If there is no .json file it searches for .layout file like before.