named parameters in up.sh; saving trajectories; trajectories replay#29
named parameters in up.sh; saving trajectories; trajectories replay#29bmielnicki wants to merge 2 commits intoHumanCompatibleAI:masterfrom
Conversation
There was a problem hiding this comment.
Wow! Thanks for adding this long-awaited feature! LGTM but would like to get feedback from @nathan-miller23
I have cloned this branch and tested it locally. It does indeed work
|
@bmielnicki just one more question, is this supposed to work with the trajectory visualization PR? |
Currently, there is no integration between this PR and HumanCompatibleAI/overcooked_ai#38 except they use the same trajectory format. I plan to get them both working together - when the player picks the trajectory file to visualize he will be able to see both the replay and the chart. |
|
Additional changes are pushed:
Next step:
As before - this change is ready to be merged after getting feedback. |
|
Extension of this PR is #30 It is separate PR because it requires review of HumanCompatibleAI/overcooked_ai#38 and I don't want to prevent merge of previous changes because of that. |

I plan to add additional stuff into this branch (like replaying trajectories from trajectory directory), but changes above seems to be mergable into master now.