Add initial candles adapter.#16
Open
svieujot wants to merge 1 commit intoHumbleSoftware:masterfrom
svieujot:master
Open
Add initial candles adapter.#16svieujot wants to merge 1 commit intoHumbleSoftware:masterfrom svieujot:master
svieujot wants to merge 1 commit intoHumbleSoftware:masterfrom
svieujot:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note : This patch assumes the candles data are also stored in options.quotes as JSON objects.
Also the dataset has an extra array :
data[0] = x // either the date or an index.
data[1] = y // I use the close
data[2] = {o:..., h:..., l:..., c: ...., v:....., d:....} // JSON for the full candle info : open, high, low, close, volume, date
This might probably need to be changed.
I did it this way to avoid changes to the envision core.