Skip to content

Update keras_optimization_helper.py#212

Open
shaoeric wants to merge 2 commits intoHunterMcGushion:masterfrom
shaoeric:master
Open

Update keras_optimization_helper.py#212
shaoeric wants to merge 2 commits intoHunterMcGushion:masterfrom
shaoeric:master

Conversation

@shaoeric
Copy link
Copy Markdown

origin helper requires tensorflow cuda9.0, however, the hunter will output nothing and stop when working on cuda10. so add some information

Copy link
Copy Markdown
Owner

@HunterMcGushion HunterMcGushion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a helpful addition! Thanks for noticing and taking the time to contribute!

Comment thread hyperparameter_hunter/compat/keras_optimization_helper.py Outdated
Comment thread hyperparameter_hunter/compat/keras_optimization_helper.py
correct Except to Exception, and add an empty line
@shaoeric
Copy link
Copy Markdown
Author

so sorry, im not familiar with pull request, but why my new commit failed

@HunterMcGushion
Copy link
Copy Markdown
Owner

No worries! It looks like the code formatting reviews are complaining about spaces on one of the empty lines (line 63). They prefer empty lines to be completely empty, so you should be able to just backspace over the spaces in that line. Sounds ridiculous, I know haha

@shaoeric
Copy link
Copy Markdown
Author

thanks

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.57%. Comparing base (96200fe) to head (3709d5e).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...rameter_hunter/compat/keras_optimization_helper.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   94.61%   94.57%   -0.04%     
==========================================
  Files          46       46              
  Lines        4956     4961       +5     
==========================================
+ Hits         4689     4692       +3     
- Misses        267      269       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants