add X-Trace-Id and traceparent headers to all HTTP calls#306
Draft
adamkorynta wants to merge 1 commit intomainfrom
Draft
add X-Trace-Id and traceparent headers to all HTTP calls#306adamkorynta wants to merge 1 commit intomainfrom
adamkorynta wants to merge 1 commit intomainfrom
Conversation
this will allow for log correlation from CDA for all logs emmitted from a single request
MikeNeilson
reviewed
Apr 22, 2026
Collaborator
MikeNeilson
left a comment
There was a problem hiding this comment.
While not nothing, the value should be per session, not per request. Or at least within a Span.
example desire:
- User clicked Extract (in HEC-RTS)
- Generate initial x-trace-id/traceparent
- All HTTP requests get those headers (and like ALL HTTP REQUESTS is valid here, but we can focus on CDAC)
- Additionally local logs would use the same x-trace-id/traceparent
- ...Profit. (actually somewhat serious there, should take far less time to correlate log entries and figure what the heck is going on for any given situation)
Collaborator
Author
|
I think if we're wanting a session id, we should add in a |
Collaborator
Author
|
It looks like OpenTelemetry uses baggage: https://opentelemetry.io/docs/concepts/signals/baggage for the client id rather than a custom header. |
MikeNeilson
approved these changes
Apr 30, 2026
rma-bryson
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will allow for log correlation from CDA for all logs emitted from a single request
See: USACE/cwms-data-api#1682