Skip to content

refactor: remove unused HTTParty dependency #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billybonks merged 1 commit into from
Mar 8, 2025
Merged

refactor: remove unused HTTParty dependency #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ source 'https://rubygems.org'

# Specify your gem dependencies here
gem 'bundler', '~> 2.2'
gem 'httparty', '~> 0.20'
Copy link

@managerbot-app managerbot-app bot Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the HTTParty dependency indicates this component will no longer make HTTP requests directly. Ensure that any functionality that relied on HTTParty has been migrated to an alternative implementation.


group :development, :test do
gem 'pry', '~> 0.15.0'
Expand Down
9 changes: 0 additions & 9 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,12 @@ GEM
crack (1.0.0)
bigdecimal
rexml
csv (3.3.2)
diff-lcs (1.6.0)
hashdiff (1.1.2)
httparty (0.22.0)
csv
mini_mime (>= 1.0.0)
multi_xml (>= 0.5.2)
json (2.10.1)
language_server-protocol (3.17.0.4)
lint_roller (1.1.0)
method_source (1.1.0)
mini_mime (1.1.5)
multi_xml (0.7.1)
bigdecimal (~> 3.1)
parallel (1.26.3)
parser (3.3.7.1)
ast (~> 2.4.1)
Expand Down Expand Up @@ -77,7 +69,6 @@ PLATFORMS

DEPENDENCIES
bundler (~> 2.2)
httparty (~> 0.20)
pry (~> 0.15.0)
rake (~> 13.0)
rspec (~> 3.12)
Expand Down
1 change: 0 additions & 1 deletion lib/committer/commit_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# frozen_string_literal: true

require 'httparty'
Copy link

@managerbot-app managerbot-app bot Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTTParty import is being removed, which suggests that commit_generator.rb no longer makes HTTP requests. Confirm that any HTTP functionality has been moved elsewhere or replaced with an alternative approach.

require 'yaml'
require_relative 'config/accessor'
require_relative 'prompt_templates'
Expand Down
Loading