Skip to content

fix(Timer): Make slave timer callbacks, well, Victor did #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorgesg82 merged 2 commits into from
Feb 10, 2026
Merged

fix(Timer): Make slave timer callbacks, well, Victor did #564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a79be7d
fix(Timer): Make slave timer callbacks, well, Victor did
FoniksFox Feb 6, 2026
67909e5
fixup tim8 interrupts a bit more
victor-Lopez25 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions Src/HALAL/Models/TimerDomain/TimerDomain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,21 +44,40 @@ extern "C" void TIM7_IRQHandler(void) {
TimerDomain::callbacks[timer_idxmap[7]](TimerDomain::callback_data[timer_idxmap[7]]);
}

/* NOTE: If it is needed, make changes so there's a specific callback for
* tim8 which takes an int or something to know from which interrupt
* it was called / make 3 callbacks
*/
extern "C" void TIM8_BRK_TIM12_IRQHandler(void) {
Comment thread
victor-Lopez25 marked this conversation as resolved.
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[8]]->SR, TIM_SR_UIF);
TimerDomain::callbacks[timer_idxmap[8]](TimerDomain::callback_data[timer_idxmap[8]]);
if((TimerDomain::cmsis_timers[timer_idxmap[12]]->SR & TIM_SR_UIF) != 0) {
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[12]]->SR, TIM_SR_UIF);
TimerDomain::callbacks[timer_idxmap[12]](TimerDomain::callback_data[timer_idxmap[12]]);
}
if((TimerDomain::cmsis_timers[timer_idxmap[8]]->SR & TIM_SR_BIF) != 0) {
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[8]]->SR, TIM_SR_BIF);
/* this could probably have some other callback */
TimerDomain::callbacks[timer_idxmap[8]](TimerDomain::callback_data[timer_idxmap[8]]);
}
Comment thread
victor-Lopez25 marked this conversation as resolved.
}

extern "C" void TIM8_UP_TIM13_IRQHandler(void) {
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[8]]->SR, TIM_SR_UIF);
TimerDomain::callbacks[timer_idxmap[8]](TimerDomain::callback_data[timer_idxmap[8]]);
if((TimerDomain::cmsis_timers[timer_idxmap[13]]->SR & TIM_SR_UIF) != 0) {
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[13]]->SR, TIM_SR_UIF);
TimerDomain::callbacks[timer_idxmap[13]](TimerDomain::callback_data[timer_idxmap[13]]);
}
if((TimerDomain::cmsis_timers[timer_idxmap[8]]->SR & TIM_SR_UIF) != 0) {
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[8]]->SR, TIM_SR_UIF);
TimerDomain::callbacks[timer_idxmap[8]](TimerDomain::callback_data[timer_idxmap[8]]);
}
Comment thread
victor-Lopez25 marked this conversation as resolved.
}

extern "C" void TIM8_TRG_COM_TIM14_IRQHandler(void) {
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[8]]->SR, TIM_SR_UIF);
TimerDomain::callbacks[timer_idxmap[8]](TimerDomain::callback_data[timer_idxmap[8]]);
if((TimerDomain::cmsis_timers[timer_idxmap[14]]->SR & TIM_SR_UIF) != 0) {
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[14]]->SR, TIM_SR_UIF);
TimerDomain::callbacks[timer_idxmap[14]](TimerDomain::callback_data[timer_idxmap[14]]);
}
constexpr uint32_t com_trg_flags = TIM_SR_TIF | TIM_SR_COMIF;
if((TimerDomain::cmsis_timers[timer_idxmap[14]]->SR & com_trg_flags) != 0) {
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[8]]->SR, com_trg_flags);
/* this could probably have some other callback */
TimerDomain::callbacks[timer_idxmap[8]](TimerDomain::callback_data[timer_idxmap[8]]);
}
}
Comment thread
victor-Lopez25 marked this conversation as resolved.

extern "C" void TIM15_IRQHandler(void) {
Expand All @@ -85,3 +104,4 @@ extern "C" void TIM24_IRQHandler(void) {
CLEAR_BIT(TimerDomain::cmsis_timers[timer_idxmap[24]]->SR, TIM_SR_UIF);
TimerDomain::callbacks[timer_idxmap[24]](TimerDomain::callback_data[timer_idxmap[24]]);
}