Minnesota #85
Minnesota #85
Conversation
|
@yuzawa-san would you mind giving this a review. We'll include it in Monday's release. |
yuzawa-san
left a comment
yuzawa-san
left a comment
There was a problem hiding this comment.
seems like delaware is leaking in
| @Override | ||
| protected List<EncodableSegment> initializeSegments() { | ||
| List<EncodableSegment> segments = new ArrayList<>(); | ||
| segments.add(new UsDeCoreSegment()); |
There was a problem hiding this comment.
UsMnCoreSegment
UsMnGpcSegment
| } | ||
|
|
||
| public Integer getSaleOptOutNotice() { | ||
| return (Integer) this.getFieldValue(UsDeField.SALE_OPT_OUT_NOTICE); |
There was a problem hiding this comment.
update all references to UsDeField to be UsMnField
There was a problem hiding this comment.
Good catch. Should be fixed now.
yuzawa-san
left a comment
yuzawa-san
left a comment
There was a problem hiding this comment.
some types appear to be inconsistent with https://github.com/InteractiveAdvertisingBureau/Global-Privacy-Platform/blob/main/Sections/US-States/MN/Minnesota%20Privacy%20Technical%20Specification.md
| fields.put(UsMnField.TARGETED_ADVERTISING_OPT_OUT, | ||
| new EncodableFixedInteger(2, 0).withValidator(nullableBooleanAsTwoBitIntegerValidator)); | ||
| fields.put(UsMnField.SENSITIVE_DATA_PROCESSING, | ||
| new EncodableFixedIntegerList(2, Arrays.asList(0, 0, 0, 0, 0, 0, 0, 0, 0)) |
There was a problem hiding this comment.
this is N-Bitfield(2,8) so one of these 0's needs to be removed
| new EncodableFixedIntegerList(2, Arrays.asList(0, 0, 0, 0, 0, 0, 0, 0, 0)) | ||
| .withValidator(nullableBooleanAsTwoBitIntegerListValidator)); | ||
| fields.put(UsMnField.KNOWN_CHILD_SENSITIVE_DATA_CONSENTS, | ||
| new EncodableFixedIntegerList(2, Arrays.asList(0, 0, 0, 0, 0)) |
There was a problem hiding this comment.
this is Int(2) so i think it needs to be new EncodableFixedInteger(2, 0).withValidator(nullableBooleanAsTwoBitIntegerValidator)
3 participants
No description provided.